【Hackathon 5th No.24】Add SubsetRandomSampler #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
changed the title
|
@lxd-cumt 劳烦看一下 |
lxd-cumt
reviewed
Oct 17, 2023
| ## API实现方案 | ||
|
|
||
| pytorch的sampler整体设计与paddle类似，因此考虑参考pytorch的方案实现 | ||
| 在 python\paddle\io\sampler.py 中添加对应类。但是由于paddle并没有完全支持`generator`，因此将该参数移除。 |
There was a problem hiding this comment.
subsetrandomsampler中__iter__方法会通过randperm函数将indices打散，并支持设置随机数生成器generator，请确认一下paddle中提供的randperm函数的用法，并且对比一下配置generator和未配置generator的区别
There was a problem hiding this comment.
paddle 中 randperm 参数如下：
paddle.randperm(n, dtype='int64', name=None)并不支持 generator。不仅是 randperm，randn、randint 等也不支持。
相关issue：
lxd-cumt
approved these changes
Oct 18, 2023
luotao1
approved these changes
Oct 18, 2023
yangguohao
pushed a commit
to yangguohao/community
that referenced
this pull request
Oct 22, 2023
* add rfc of SubsetRandomSampler * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add rfc of SubsetRandomSampler
和代码同步修改