【Hackathon 5th No.31】为 Paddle 新增 column_stack / row_stack / dstack / hstack / vstack API #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhwesky2010
reviewed
Oct 11, 2023
| - `paddle.vstack`，作为独立的函数调用 | ||
| - `Tensor.vstack`，作为 Tensor 的方法使用 | ||
|
|
||
| **疑问** ： 这些接口为什么会有 `Tensor.XXX` 的方法？一般堆叠都是对多个 Tensor 的操作，另外，`PyTorch`、`Numpy` 也没有类似的使用方法，还请确认一下。 |
| 添加 python 上层接口: | ||
|
|
||
| - `paddle.column_stack(x, name=None)` | ||
| - `Tensor.column_stack` (有疑问) |
|
|
||
| - **维度测试** | ||
| - Paddle API 支持的最低维度为 0 维，单测中应编写相应的 0 维尺寸测试 case | ||
|
|
There was a problem hiding this comment.
OK，需要有异常测试的，我尽快更新一下 ～ 谢谢！
| 需要保证前向计算的精度正确性，通过 numpy 实现的函数的对比结果 | ||
|
|
||
| - **维度测试** | ||
| - Paddle API 支持的最低维度为 0 维，单测中应编写相应的 0 维尺寸测试 case |
|
非常抱歉拖了多日才更新，此次更新：
请评审～ 非常感谢！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Docs
Description
【Hackathon 5th No.31】为 Paddle 新增 column_stack / row_stack / dstack / hstack / vstack API
请评审！