Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 5th No.29】为 Paddle 新增 cholesky_inverse API #724

Closed
wants to merge 2 commits into from
Closed

【Hackathon 5th No.29】为 Paddle 新增 cholesky_inverse API #724

wants to merge 2 commits into from

Conversation

kafaichan
Copy link

No description provided.

Copy link

paddle-bot bot commented Nov 3, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@kafaichan kafaichan changed the title 【Hackathon 5th No.29】为 Paddle 新增 cholesky_inverse API (#724) 【Hackathon 5th No.29】为 Paddle 新增 cholesky_inverse API Nov 4, 2023
- **name** (str, 可选) - 具体用法请参见 :ref:`api_guide_Name` ,一般无需设置,默认值为None。

- Returns
- Tensor, 如果upper为True, 返回$(U^{T}U)^{-1}$,否则返回$(LL^{T})^{-1}$

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这儿渲染显示有点问题,辛苦修改一下

Copy link
Author

@kafaichan kafaichan Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个已修改,麻烦在看看。


# 六、测试和验收的考量
1. 结果正确性:
- 前向计算: `paddle.cholesky_inverse`计算结果与 `torch.cholesky_inverse` 计算结果一致。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

合入框架需要添加OpTest相关测试,numpy没有相应函数的话需要自行组合。线下验证过程中可以跟torch进行对比。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kafaichan 请问这个意见改完了么

@luotao1 luotao1 closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants