【Hackathon 6th No.8】为 Paddle 新增FeatureAlphaDropout API #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MagnetoWang
changed the title
zxcd
reviewed
May 8, 2024
|
|
||
| 参数表： | ||
|
|
||
| - input: (Tensor) 输入的 tensor。维度至少大于2 |
There was a problem hiding this comment.
align with other API, suggest use 'x'.
| # 四、对比分析 | ||
|
|
||
| 对比 PyTorch : | ||
| - PyTorch 有 cpp 和 cuda 两种实现方法 |
zxcd
reviewed
May 8, 2024
|
|
||
| # 六、测试和验收的考量 | ||
|
|
||
| - 覆盖 CPU 测试场景，暂不考虑GPU场景 |
There was a problem hiding this comment.
分三期做吧，一期是python接口实现，稳定后，二期，出于性能优化，实现一版cpp算子，三期，再优化实现一版cuda的gpu算子
| # 六、测试和验收的考量 | ||
|
|
||
| - 覆盖 CPU 测试场景，暂不考虑GPU场景 | ||
| - 支持各种Tensor精度，FP32、FP64 等（待验证） |
There was a problem hiding this comment.
should support more date types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add rfcs