[CodeStyle] upgrade Lucas-C/pre-commit-hooks in .pre-commit-config.yaml
#6240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-6240.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html |
SigureMo
reviewed
Oct 22, 2023
| @@ -60,7 +60,7 @@ body: | |||
| attributes: | |||
| label: 1.导入分布式训练需要的依赖包 | |||
| description: | | |||
| 针对 导入分布式训练需要的依赖 这一环节，请回答以下内容 | |||
| 针对 导入分布式训练需要的依赖 这一环节，请回答以下内容 | |||
There was a problem hiding this comment.
Suggested change
| 针对 导入分布式训练需要的依赖 这一环节，请回答以下内容 | |
| 针对「导入分布式训练需要的依赖」这一环节，请回答以下内容 |
改成这样吧，下同
| - id: remove-tabs | ||
| files: \.md$|\.rst$ | ||
| types: [text] |
There was a problem hiding this comment.
两个 forbid 可以删掉，因为和 remove 重复了，可以参考 Paddle 那边的，同样，下面的 check-whitespace-between-cn-and-en-char 之后也可以删掉，因为 insert-whitespace-between-cn-and-en-char 会既检查又修复
ci_scripts/gendoc.sh
Outdated
Comment on lines
35
to
38
| tmp_fifofile=/tmp/$$.fifo #脚本运行的当前进程ID号作为文件名 | ||
| mkfifo $tmp_fifofile #新建一个随机fifo管道文件 | ||
| exec 6<>$tmp_fifofile #定义文件描述符6指向这个fifo管道文件 | ||
| rm $tmp_fifofile #清空管道内容 |
There was a problem hiding this comment.
Suggested change
| tmp_fifofile=/tmp/$$.fifo #脚本运行的当前进程ID号作为文件名 | |
| mkfifo $tmp_fifofile #新建一个随机fifo管道文件 | |
| exec 6<>$tmp_fifofile #定义文件描述符6指向这个fifo管道文件 | |
| rm $tmp_fifofile #清空管道内容 | |
| tmp_fifofile=/tmp/$$.fifo # 脚本运行的当前进程ID号作为文件名 | |
| mkfifo $tmp_fifofile # 新建一个随机fifo管道文件 | |
| exec 6<>$tmp_fifofile # 定义文件描述符6指向这个fifo管道文件 | |
| rm $tmp_fifofile # 清空管道内容 |
ci_scripts/gendoc.sh
Outdated
Comment on lines
71
to
72
| wait #等到后台的进程都执行完毕 | ||
| exec 6>&- ##删除文件描述符6 |
There was a problem hiding this comment.
Suggested change
| wait #等到后台的进程都执行完毕 | |
| exec 6>&- ##删除文件描述符6 | |
| wait # 等到后台的进程都执行完毕 | |
| exec 6>&- # 删除文件描述符6 |
docs/templates/layout.html
Outdated
| @@ -2,7 +2,7 @@ | |||
| {# Import the theme's layout. #} | |||
| {% extends "!layout.html" %} | |||
|
|
|||
| {# SIDE NAV, TOGGLES ON MOBILE #} | |||
| {# SIDE NAV, TOGGLES ON MOBILE #} | |||
There was a problem hiding this comment.
Suggested change
| {# SIDE NAV, TOGGLES ON MOBILE #} | |
| {# SIDE NAV, TOGGLES ON MOBILE #} |
直接删掉，不然会和另一个 PR 冲突
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link #6158
升级 docs repo 中现有的代码风格检查工具版本
tracking issue 待补充
@SigureMo