Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docathon][CodeStyle] refine ci and pre-commit #6253

Merged
merged 7 commits into from
Oct 27, 2023

Conversation

ooooo-create
Copy link
Collaborator

link #6242

  • 优化 CI 显示效果,只运行一次 pre-commit
  • 优化 ci 里各项检查的显示效果,使得根据报错信息直观找到问题所在
    删除 ci 中重复的 if [ $? -ne 0 ]

@SigureMo

@paddle-bot
Copy link

paddle-bot bot commented Oct 25, 2023

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6253.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o 师傅整几个 code style 有问题的文件测一下吧,commit 时候加 --no-verfiy 可以保证即便有问题也可以 commit

@ooooo-create
Copy link
Collaborator Author

o 师傅整几个 code style 有问题的文件测一下吧,commit 时候加 --no-verfiy 可以保证即便有问题也可以 commit

一师傅,是这个--no-verify

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

这个路径是不是不太对,应该因为原脚本是在子目录执行的,是否可以修改成在项目根目录执行,这样就没这个问题了

@SigureMo
Copy link
Member

一师傅,是这个--no-verify~

😂 现在不像以前写个 comment 还要检查好几遍,经常会有 typo 了 [doge]

@@ -118,13 +118,15 @@ if [ "${need_check_cn_doc_files}" = "" ] ; then
else
/bin/bash -x ${DIR_PATH}/check_api_cn.sh "${need_check_cn_doc_files}"
if [ $? -ne 0 ];then
echo "ERROR: Exist COPY-FROM has not been parsed into sample code, please check COPY-FROM in the above files"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些也用 ************************************************************************************ 包裹吧

这样的子问题用 *,summary 用 =,会统一一些

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来基本可以了,恢复下测试相关修改吧

LGTMeow

@SigureMo SigureMo merged commit f654f19 into PaddlePaddle:develop Oct 27, 2023
3 checks passed
@SigureMo SigureMo added the HappyOpenSource 快乐开源活动issue与PR label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants