Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docathon][Add API Legend No.6]add the picture of crop #6786

Merged
merged 9 commits into from
Sep 25, 2024
Merged

[Docathon][Add API Legend No.6]add the picture of crop #6786

merged 9 commits into from
Sep 25, 2024

Conversation

Aoraki-Dream
Copy link
Contributor

No description provided.

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jul 24, 2024

感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-6786.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明，请参考：飞桨文档预览工具

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Aoraki-Dream
Copy link
Contributor Author

增加crop图示
@sunzhongkai588

@luotao1 luotao1 mentioned this pull request Jul 24, 2024
Open
sunzhongkai588
sunzhongkai588 reviewed Jul 24, 2024
View reviewed changes
docs/api/paddle/crop_cn.rst Outdated
Comment on lines 61 to 64
.. figure:: ../../images/api_legend/crop.png
:alt: 示例二图示
:align: center
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. figure:: ../../images/api_legend/crop.png
:alt: 示例二图示
:align: center
.. figure:: ../../images/api_legend/crop.png
:width: 500
:alt: 示例二图示
:align: center

把图片调小一些，有些太大啦

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK，已修改

docs/images/api_legend/crop.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很清晰～就是有几个可以优化的地方

  • 每个 axis 轴刻度的间隔都为 1 吧， 比如 0 ... 1，小数没太大意义
  • 每个位置都元素可以放大一些（小圆点以及其数字），或者小圆点改成小方块

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的，已修改

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 24, 2024
@Aoraki-Dream Aoraki-Dream mentioned this pull request Jul 26, 2024
Closed
44 tasks
sunzhongkai588
sunzhongkai588 reviewed Jul 30, 2024
View reviewed changes
docs/images/api_legend/crop.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个图片是不是没截全？ 最上面的 Original Tensor 截了一半

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已调整

@sunzhongkai588
Copy link
Collaborator

CLA也签署一下

@luotao1 luotao1 closed this Aug 26, 2024
@luotao1 luotao1 reopened this Aug 26, 2024
@Aoraki-Dream
Copy link
Contributor Author

完成修改@sunzhongkai588

sunzhongkai588
sunzhongkai588 reviewed Sep 5, 2024
View reviewed changes
docs/images/api_legend/crop.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

临时加个需求，可以换种表现形式吗，更加直观一点，比如
image

参考 https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/guides/beginner/tensor_cn.html#span-id-newtensor1-2-1-span

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改，请求review @sunzhongkai588

sunzhongkai588
sunzhongkai588 reviewed Sep 6, 2024
View reviewed changes
docs/images/api_legend/crop.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry 是我之前没说清楚～

  • 方向键上的数字替换为轴，比如 axis=0 ....
  • 同一tensor的两张图可以靠的近一些，显得更加立体

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的，已修改 @sunzhongkai588

sunzhongkai588
sunzhongkai588 reviewed Sep 9, 2024
View reviewed changes
docs/images/api_legend/crop.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

图维度好像写错了..按这个来的话，变成了 [2,2,2] -> [1,2,2]
一般来说，3d tesnro 里 axis =1 代表矩阵的行， axis = 2 代表矩阵的列 ，axis = 0 代表有几个矩阵（这么说其实不准确，但为了方便你理解）

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

明白了，已修改 @sunzhongkai588

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Sep 10, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Sep 10, 2024
sunzhongkai588
sunzhongkai588 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，英文文档同步加一下

@luotao1 luotao1 merged commit 1514d70 into PaddlePaddle:develop Sep 25, 2024
2 checks passed
This was referenced Sep 25, 2024
Closed
Merged
@Aoraki-Dream
Copy link
Contributor Author

同步修改英文文档 PaddlePaddle/Paddle#68462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

Assignees

@luotao1 luotao1

@sunzhongkai588 sunzhongkai588

Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aoraki-Dream @CLAassistant @sunzhongkai588 @luotao1