Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 7th No.31】NO.31 为 paddle.sparse.sparse_csr_tensor进行功能增强 -part #6876

Merged
merged 1 commit into from
Sep 24, 2024
Merged

【Hackathon 7th No.31】NO.31 为 paddle.sparse.sparse_csr_tensor进行功能增强 -part #6876

merged 1 commit into from
Sep 24, 2024

Conversation

monster1015
Copy link
Contributor

No description provided.

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Sep 18, 2024

感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-6876.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明，请参考：飞桨文档预览工具

@luotao1 luotao1 mentioned this pull request Sep 18, 2024
Open
@luotao1 luotao1 added the PaddlePaddle Hackathon 飞桨黑客松活动issue与PR label Sep 18, 2024
zhwesky2010
zhwesky2010 reviewed Sep 18, 2024
View reviewed changes
docs/guides/model_convert/convert_from_pytorch/api_difference/torch/torch.sparse_csr_tensor.md
| crow_indices | crows | 每行第一个非零元素在 values 的起始位置，仅参数名不一致。 |
| col_indices | cols | 一维数组，存储每个非零元素的列信息，仅参数名不一致。 |
| values | values | 一维数组，存储非零元素。 |
| size | shape | 稀疏 Tensor 的形状，仅参数名不一致。 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

验证一下，这个自动推导的结果与Pytorch是完全一致的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

验证过了的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

然后paddle和pytorch不同的是，paddle是只能一维向量，pytorch是多维向量

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所以paddle在切割一维向量后，需要判断每个子向量包含的数字个数是不是相同的

Copy link
Collaborator

@zhwesky2010 zhwesky2010 Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

然后paddle和pytorch不同的是，paddle是只能一维向量，pytorch是多维向量

什么是一维向量，没看明白差异。

要从torch角度往paddle看，torch的所有用法情况都可以被paddle覆盖，则视为一致，即使paddle有更多功能也不用管

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是指输入的参数维度

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

稍等，我给个例子

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

而在paddle中，输入是这样的
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK，看起来是paddle与torch的csr tensor，在3D情形下的设计是不一致的，paddle为展平式的设计

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

zhwesky2010
zhwesky2010 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 5f90eef into PaddlePaddle:develop Sep 24, 2024
2 checks passed
@luotao1
Copy link
Collaborator

luotao1 commented Sep 24, 2024

hi, @monster1015

  • 非常感谢你对飞桨的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨做贡献，详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣，请发送邮件至 ext_paddle_oss@baidu.com，我们会邀请你加入~

@luotao1 luotao1 changed the title 【Hackathon 7th No.31】NO.31 为 paddle.sparse.sparse_csr_tensor进行功能增强 【Hackathon 7th No.31】NO.31 为 paddle.sparse.sparse_csr_tensor进行功能增强 -part Sep 24, 2024
@luotao1
Copy link
Collaborator

luotao1 commented Sep 27, 2024

hi, @monster1015

  • 非常感谢你对飞桨的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨做贡献，详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣，请发送邮件至 ext_paddle_oss@baidu.com，我们会邀请你加入~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees

@luotao1 luotao1

@zhwesky2010 zhwesky2010

@sunzhongkai588 sunzhongkai588

Labels
contributor PaddlePaddle Hackathon 飞桨黑客松活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@monster1015 @CLAassistant @luotao1 @zhwesky2010 @sunzhongkai588