-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the transposed conv2d initializer. #984
Change the transposed conv2d initializer. #984
Conversation
@@ -48,14 +49,16 @@ class PyramidBox(object): | |||
def __init__(self, | |||
data_shape, | |||
num_classes, | |||
use_transposed_conv2d=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
用户需要知道use_transposed_conv2d=False
的时候用的是什么upsampling方法么?
upsampling_method='transposed_conv' or 'resize_bilinear'会不会更直观?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wanghaoshuang Thanks, I'll add comments later.
fluid/face_detection/pyramidbox.py
Outdated
param_attr=w_attr, | ||
bias_attr=False) | ||
else: | ||
conv_up = fluid.layers.resize_bilinear( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conv_up
改成 upsampling
会不会更好些?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些小问题后续可以另提PR修改。
Fix #985