Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Feature/Parameter #44

Merged
merged 4 commits into from
Jun 29, 2018
Merged

Feature/Parameter #44

merged 4 commits into from
Jun 29, 2018

Conversation

tonyyang-svail
Copy link
Collaborator

fix #37

@tonyyang-svail tonyyang-svail mentioned this pull request Jun 29, 2018
Open
36 tasks
kexinzhao
kexinzhao approved these changes Jun 29, 2018
View reviewed changes
Copy link
Collaborator

@kexinzhao kexinzhao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

One minor thing: BN has optimizable parameters scale and bias, and non optimizable parameters mean_ and variance_. I will fix this in my PR.

@kexinzhao kexinzhao merged commit 2afb7a0 into PaddlePaddle:develop Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kexinzhao kexinzhao kexinzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Parameter as a derived class of Variable
2 participants
@tonyyang-svail @kexinzhao