Allow time_window to be set for content-based grouping (issue 788) #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I successfully tested this fix against my workload. |
|
@imjaroiswebdev is it possible to get workflow approval for this and have someone review this PR? |
fix typo in test. update `pagerduty_service` docs`. patch `pagerduty_service` format failing tests.
imjaroiswebdev
force-pushed
the
buffyg-patch-1
branch
from
d2fe98d to
c0b86e1
Compare
imjaroiswebdev
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Thank you improving this @buffyg 👏🏽 very appreciated contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #788
Very simple change, little bit of renaming since this is no longer specific to intelligent grouping w/ test coverage updated to reflect changes to error strings and cover new cases.