Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address: Service DS not locating queried name when is not in first page of results #874

Merged

Conversation

imjaroiswebdev
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev commented May 20, 2024

Closes #872

Following GH Gist should work to validate the issue is patched.

Acceptance tests results...

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccDataSourcePagerDutyService -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
=== RUN   TestAccDataSourcePagerDutyService_Basic
--- PASS: TestAccDataSourcePagerDutyService_Basic (16.10s)
=== RUN   TestAccDataSourcePagerDutyService_HasNoTeam
--- PASS: TestAccDataSourcePagerDutyService_HasNoTeam (14.24s)
=== RUN   TestAccDataSourcePagerDutyService_HasOneTeam
--- PASS: TestAccDataSourcePagerDutyService_HasOneTeam (15.44s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     46.741s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       1.158s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  1.146s [no tests to run]

@imjaroiswebdev imjaroiswebdev merged commit 58ebcee into PagerDuty:master May 20, 2024
1 check passed
@imjaroiswebdev imjaroiswebdev deleted the ds-user-paginate-results branch May 20, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant