Add the option to ignore TLS certificate errors when calling the PD API. #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dazoakley
force-pushed
the
insecure-tls
branch
2 times, most recently
from
1402750 to
6a36a3c
Compare
imjaroiswebdev
requested changes
Jun 13, 2024
There was a problem hiding this comment.
Hey there @dazoakley! Great addition, only thing missing is to also add the update for SlackClient and We should be ready to merge. Additionally, please rebase onto master. Thanks!
This is useful when you're behind a corporate proxy that messes with with the certificates...
dazoakley
force-pushed
the
insecure-tls
branch
2 times, most recently
from
af15b12 to
d0bac8b
Compare
imjaroiswebdev
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
Thanks for the awesome module.
This is my first attempt at writing terraform provider code (and I'm pretty green to golang) so please be gentle. 😄
This update makes it possible to ignore TLS certs if you really really need to, i.e. when you're behind a corporate proxy that messes with with the certificates...
Is this something you'd accept as a change? I've tested it on our CI server and it applies nicely.
I wasn't sure if I should update the changelog or not, please let me know and I can remove that edit if needed.
Thanks!