Bug Fix: Unable to logout after initial login ( closes 1581 ) #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gives sample demo for `TalawaPluginProvider `
…ibility in navbar
SiddheshKukade
changed the title
SiddheshKukade
commented
Mar 5, 2023
Comment on lines
23
to
24
| import 'package:talawa/widgets/custom_progress_dialog.dart'; | ||
|
|
||
| import '../../../widgets/custom_progress_dialog.dart'; |
There was a problem hiding this comment.
Refractor: This is the conventional way of importing packages.
SiddheshKukade
commented
Mar 5, 2023
Comment on lines
88
to
95
| try { | ||
| Firebase.app() | ||
| .delete(); // Deleting app will stop all Firebase plugins | ||
| } catch (e) { | ||
| debugPrint( | ||
| "ERROR: Unable to delete firebase app" + e.toString()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Fix: Firebase throws error if it's not initialized previously. Added a try {..} catch{..} to fix it,
|
Closing. You are not assigned the issue. |
|
Reopening as the assignee asked that you work on it. |
Codecov Report
@@ Coverage Diff @@
## develop #1620 +/- ##
===========================================
+ Coverage 77.34% 80.38% +3.04%
===========================================
Files 145 145
Lines 7216 7275 +59
===========================================
+ Hits 5581 5848 +267
+ Misses 1635 1427 -208
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@palisadoes Sir, the code is ready to be reviewed. |
palisadoes
approved these changes
Mar 5, 2023
ikjot-2605
pushed a commit
to ikjot-2605/talawa
that referenced
this pull request
Mar 8, 2023
…doesFoundation#1620) * Create .gitpod.yml * Create .gitpod.Dockerfile * Add/temp-file * Add/temp-plugin gives sample demo for `TalawaPluginProvider ` * remove/unecessary-files#1 * remove/unecessary-files#2 * Add/TalwaPluginProvider * Add/queries `getPluginsList` * Docs for 'TalawaPluginProvider' * `Add/fetch_plugin_list` * Refractoring & adding `fetchPlugins` in main * Delete sa.dart * Delete tempPlugin.dart * Test/ `Tawla Plugin Provider` * Refractor : Added `Braintree` config in AndroidManifest.xml * Refractor : Added `Talawa_plugin_provider_nav` to control plugins visibility in navbar * Update : Main file setState fix * Changed ios version from `10.0` to `12.0` * Add : `Donation` feature as Plugin with braintree API * Add : `createDonation` Mutation * Fix : `Plugin` render bug * Chores : Formatted files * Add : `navBarItems` (features) as plugins * Chores : Formatting * Update : Profile removed key * Chores : Add `Flutter_Braintree` * Chores : Fix `Lint errors` * Fix : Formatting Errors * Delete talawa_plugin_provider_nav.dart * Update pull-request.yml * Added a empty line in main * Update pull-request.yml * Fix : Faling tests * Fix : Failing test PalisadoesFoundation#2 commented out `teste.pumpAndSetttle` * Remove : all the changes done in the `custom_drawer_test.dart` Removed everthing that I've added to check if it will pass the test or not. * PR Fail Fix Attempt PalisadoesFoundation#1 : Added `fetchPluginLIst` in `main.dart` * PR Fail Fix Attempt PalisadoesFoundation#2 : Commenting test cases to check furthur problems * Chores : Commented Imports * Deleted : Test file * Fix: Trigger workflow * Add : Faling test back `custom_drawer_test.dart` * Add Test for `utils/query.dart` * Add : Tests `queries_test.dart` * Add : Tests `chat_queries_test.dart` * Add : Test for `comment_queries_test.dart` * Add : test for `event_queries_test` * Add : test for `post_qurie..dart` * Add : test for `post_query.dart` * Add : test for `task_queries.dart` * Add : test for `utils/validator.dart` * Fix : failing tests * Test : Failing test uncommented `custom_drawer_test.dart` * Fix : Commented `custom_drawer_test.dart` * removed utils tests * Removed Commented Code * add/table of contents and link to installation file. * Add/ Date validation closes PalisadoesFoundation#1590 * Add Import * Add/ Date validation closes PalisadoesFoundation#1590 * Fix login bug closes PalisadoesFoundation#1581 * removed extra changes * CI CD FIX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Logout feature was not working I've fixed the issue.
Issue Number:
Fixes #1581
Did you add tests for your changes?
Not required
Snapshots/Videos:
talawa.023.rea.mp4
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
yes