-
-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Bugfix & Docs ] Overflow issue on Explore events closes #1561 & Adding documentation for explore_events.dart #1640
[ Bugfix & Docs ] Overflow issue on Explore events closes #1561 & Adding documentation for explore_events.dart #1640
Conversation
gives sample demo for `TalawaPluginProvider `
…ibility in navbar
@palisadoes @noman2002 Sir, the CI/CD fails due to absent code documentation. Can I add it here in this PR and create an separate issue about "Adding documentation for |
@SiddheshKukade from today on, contributors are required to write documentation for each file they are modifying in their PR. Please look at my pinned message in #talawa Slack channel for more information. |
@SiddheshKukade do you get lint errors in your IDE now ? Do you think we need a detailed guide on the new lint rules and the format we are expecting ? Or is it self explanatory from the warning generated ? |
Please add it here. It's the new process and is documented |
@SiddheshKukade please read the documentation format we are expecting. It is in our talawa-docs site. |
Codecov Report
@@ Coverage Diff @@
## develop #1640 +/- ##
===========================================
+ Coverage 80.48% 80.62% +0.14%
===========================================
Files 144 144
Lines 7271 7272 +1
===========================================
+ Hits 5852 5863 +11
+ Misses 1419 1409 -10
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What kind of change does this PR introduce?
Bugfix
Issue Number:
Fixes #1561
Did you add tests for your changes?
Not required
Snapshots/Videos:
If relevant, did you update the documentation?
Not required
Summary
Reduced the size of the row to remove the overflow
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes