Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Bugfix & Docs ] Overflow issue on Explore events closes #1561 & Adding documentation for explore_events.dart #1640

Merged

Conversation

SiddheshKukade
Copy link
Member

@SiddheshKukade SiddheshKukade commented Mar 8, 2023

What kind of change does this PR introduce?

Bugfix

Issue Number:

Fixes #1561

Did you add tests for your changes?
Not required
Snapshots/Videos:
Screenshot_2023-03-07-14-33-32-870_com.example.talawa.jpg

If relevant, did you update the documentation?

Not required

Summary
Reduced the size of the row to remove the overflow
Does this PR introduce a breaking change?
No

Have you read the contributing guide?
Yes

@SiddheshKukade
Copy link
Member Author

@palisadoes @noman2002 Sir, the CI/CD fails due to absent code documentation. Can I add it here in this PR and create an separate issue about "Adding documentation for explore_events.dart " file and link that here, just to keep track of these bugfix and documentation separately ?

@SiddheshKukade SiddheshKukade changed the title [ Bugfix ] Overflow issue on Explore events closes #1561 [ Bugfix & Docs ] Overflow issue on Explore events closes #1561 & Adding documentation for explore_events.dart Mar 8, 2023
@literalEval
Copy link
Member

@SiddheshKukade from today on, contributors are required to write documentation for each file they are modifying in their PR. Please look at my pinned message in #talawa Slack channel for more information.

@literalEval
Copy link
Member

literalEval commented Mar 8, 2023

@SiddheshKukade do you get lint errors in your IDE now ? Do you think we need a detailed guide on the new lint rules and the format we are expecting ? Or is it self explanatory from the warning generated ?
Any feedback will be much appreciated. Thanks.

@palisadoes
Copy link
Contributor

Please add it here. It's the new process and is documented

@literalEval
Copy link
Member

@SiddheshKukade please read the documentation format we are expecting. It is in our talawa-docs site.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #1640 (b0fa499) into develop (6211a88) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1640      +/-   ##
===========================================
+ Coverage    80.48%   80.62%   +0.14%     
===========================================
  Files          144      144              
  Lines         7271     7272       +1     
===========================================
+ Hits          5852     5863      +11     
+ Misses        1419     1409      -10     
Impacted Files Coverage Δ
...iews/after_auth_screens/events/explore_events.dart 97.32% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@palisadoes palisadoes merged commit e84aed9 into PalisadoesFoundation:develop Mar 11, 2023
@SiddheshKukade SiddheshKukade deleted the fix-1561-overflow branch April 14, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow Issue on Events Page
4 participants