Language selector UI #837
Merged
Language selector UI #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mentors, please review PR #829 first and after its merge, review this PR. |
|
@palisadoes @Sagar2366 @DeltaHarbinger This PR is also ready for the review. |
|
@sumitra19jha merge this into the GSoC branch. |
|
This is the Language Selector update for Master Branch. |
|
@sumitra19jha all changes LGTM but please look into the test as this PR is based to master branch and there are few contributors still working to fix some bugs. Is this feature going to be implemented again for the GSoC branch codebase in another PR or will this we shipped as it is? |
|
@CyberWake This PR is specifically targeted at the master branch. The new one is coming for the GSoC branch. Once this PR is merged, contributors will not use hardcoded string, this development quality will be enhanced. |
|
@palisadoes @CyberWake @rutvik11062000 @utkarshshendge Please review |
|
@CyberWake @rutvik11062000 @utkarshshendge Please review. We need 2 reviewers on the master branch to merge. |
palisadoes
previously approved these changes
Jun 3, 2021
|
@sumitra19jha #829 needs to be merged before this right? |
|
@utkarshshendge Yes I would recommend that, but merging this PR first also won't effect the app working. But please go through string refactoring first. |
|
@sumitra19jha please resolve the conflicts. |
… into language-selector
|
@CyberWake @utkarshshendge @rutvik11062000 @palisadoes Conflict Resolved |
palisadoes
approved these changes
Jun 6, 2021
|
@CyberWake @utkarshshendge @rutvik11062000 this needs one more review before it can be merged. |
Sagar2366
approved these changes
Jun 6, 2021
palisadoes
added a commit
that referenced
this pull request
Jun 26, 2021
…ch merge (#900) * setting up the router * minor fixes * removed unneccasry const keywords * Hiding FAB on reaching end of list * set newsfeed-set_url_page naigation * Update tests regarding the navigation change * Add Posts Model * Implementing Posts Model * Change in newsfeed.dart * event_controller * Group controller * linter fix * PR checks fix * Flutter format * ptch: flutter format linter * refactored the code * Revert "refactored the code" This reverts commit 9a7ddb6. * test * controller add * query update * tile addition * pagination * flutter format * ptch: Add & Implement EventsModal * ptch: Add & Implement OrgMember * script for automatically adding trailing commas * added description to the funtions, added the script in pull-request.yml * refac: fixes linting issues * Logic correction and flutter formatting * Added MVVM * Added mdoel to the locator and debugging * Flutter Format * Fixing travis tests * Add FutureBuilder Logic To Main.dart * logic correction * setted MVVM structure * Attached viewModel * reduced lines * refactored and completed local device test. * updated tests * Add news_article+page_view_model.dart * Implements the ViewModel * ptch: Updated the Test * ptch: flutter linting * logic correction * minor error fixing after merge conflict * minor error fixing after merge conflict * minor error fixing after merge conflict * Flutter format * Fixing errors * Updated Tests * ptch: Adding Comment Bug Fix * ptch: flutter linitng * ptch: test update * Fixed code formatting * bfix: fixes comment count not updating on newsfeed * ptch: Change in Loader * ptch: Change in Loader * ptch: added default parameter in Loader * logic correction * upstream fetch * Flutter format . * conflict * Url controller * url page controller addn * controller registration * Unused files removal * Adding test * conflict resoved * fixing tests * Fixed errors * Flutter format . * Flutter Format * Merge remote-tracking branch 'upstream/master' into newPagination * flutter format . * flutter format * flutter format . * Fixes #793 * flutter format . * fixed changes * flutter format * Merge remote-tracking branch 'upstream/master' into provider-add * flutter format . * fixed formatting * Fixed formatting * Merge remote-tracking branch 'upstream/master' into provider-add * Merge remote-tracking branch 'upstream/master' into provider-add * Fixed travis build fail * chore: fixes linting issue * events update * ptch: Flutter lint * ptch: Replace the Column with Listview in Loader.dart * controlller add * flutter format . * Image Handler * Image Ui and Controller Connection * Test Updates * uniformisation * Code style prttification * app localization and language controller addition * language * logic correction with generalised approach rather than specific case-wise approach * change of a minor error in pull-request.yml * addition of justified docstrings and methodogy * correction of a specific case in group_controller.dart's formatting * increasing the legibility of the code * removed usused import from post_cotroller.dart for resubmitting for the build * Fix : Not able to close pop up in Join Organization Screen #815 Bug was caused due to Page context was used in close button instated new context of builder. Fix: Refactor : ctx -> dialogContext Change : context -> dialogContext (line 142) * undoing the change in pubspec.yaml for travis CI build * Splash Screen Added * travis ci fix * fix * http ^0.12.0+4 * fix * dependency overide * dependency overide * dependency change * compatible packages * adding crypto 2.1.3 * crypto: 3.0.1 * To rerun travis ci * Done : code formatting * Red screen error resolved from the update profile page(Issue #824) * [Fix] RenderFlex overflow in Member details Screen * Merge branch 'functionality-to-crop-picture' of https://github.com/afaanshariff/talawa into functionality-to-crop-picture * resolved merge conflicts * resolved exceptions in image_service.dart * resolved exceptions in image_service.dart * Organisation setting bug fix - Fixes bug #833 - Code reformatting of profile_page_viewModel.dart and profile_page.dart * Updated CONTRIBUTING.md with new Branching Strategy * Removed gitflow from CONTRIBUTING.md * Fixed typo in CONTRIBUTING.md * User will not able to delete others event fix #832 * Simplification of LeaveOrg and OrgSetting Button * Using snake case in file names - Flutter SDK was showing Warning as the Camel case was used in the file names so the file was renamed as snake case. * Organisations directory file size reduction - dart file size reduction (under 300 lines) of files under "lib/views/pages/organization" directory - Code refactored and reformatted * Users can't see an option to delete if they are not allowed * Fixes #840 * Fixes #840 * Minor change : Ternary operators removed * event_dialog file size reduction - Widgets common between add_event_dialog.dart and edit_event_dialog.dart have been separated into file event_widgets.dart - Data is passed as parameter - Register form also reformatted * Organization names are displayed in sorted order. * File size reduction set_url_page.dart * Reformatted - Reformatted with flutter format - URL Page Animation extracted and moved to other file * Update register_form_test.dart * Update pull_request_template.md * String refactoring (#829) * lang addition * lng-add * static string removal * language changes * chgs in main * test update * Language selector UI (#837) * ui added * adding lng widget * bug fix * test upd * Edit Event page bug fix (#875) * [Fix] Event list shows wrong data after deleting an event (#817) * chore: fixes linting issue * ptch: replaces event list with displayed events list * Refactor of the toast widget and deletion of `snackbar.dart` (#813) * Replacing extra widgets for toasts with Custom Toast and making it uniform * removed snackbar.dart due to no implementation * flutter format * merge conflict resolved Co-authored-by: rutvik11062000 <rutvik.chandla@gmail.com> Co-authored-by: Brandon Chung <deltaharbinger@gmail.com> Co-authored-by: Astha Nayak <nayakastha2911@gmail.com> Co-authored-by: raunak_k02 <raunakk728@gmail.com> Co-authored-by: ahluwaliatikant <atikant.ahluwalia@gmail.com> Co-authored-by: StrangeNoob <sipun63427452@gmail.com> Co-authored-by: Sumitra Saksham <sumitra19jha@gmail.com> Co-authored-by: afaanshariff <afaanshariff29@gmail.com> Co-authored-by: Troy Anderson <33005486+TheHazeEffect@users.noreply.github.com> Co-authored-by: Shreyash Lata <shreyeslata@gmail.com> Co-authored-by: Sagar Utekar <sagarutekar2366@gmail.com> Co-authored-by: Peter Harrison <blackriver@simiya.com> Co-authored-by: AFFAN SHARIFF <57586853+afaanshariff@users.noreply.github.com> Co-authored-by: Aditya Birangal <aditya.birangal@gmail.com> Co-authored-by: Sumitra Saksham <35868598+sumitra19jha@users.noreply.github.com> Co-authored-by: Muskan Modi <500068213@stu.upes.ac.in> Co-authored-by: Muskan Modi <63671368+muskan399@users.noreply.github.com> Co-authored-by: Aman Anand <itsamananand@gmail.com> Co-authored-by: DangaRanga <jasonblue1626@gmail.com> Co-authored-by: Piyush Goel <piyushgoel2008@gmail.com> Co-authored-by: Raunak Kumar <56073198+Raunakk02@users.noreply.github.com>
Ayush0Chaudhary
pushed a commit
to Ayush0Chaudhary/talawa
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Closes #801
Did you add tests for your changes?
No, a Separate issue is already created for it
If relevant, did you update the documentation?
Not required
Summary
Does this PR introduce a breaking change?
No
Other information
whatsapp-video-2021-05-23-at-75216-pm_EbZ6f3dG_w45K.mp4