Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide defaults if setting is undefined #7

Merged
merged 1 commit into from
Sep 25, 2024
+4 −4
Merged

Provide defaults if setting is undefined #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hooks/persisted/useSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export interface AppSettings {
export interface BrowseSettings {
showMyAnimeList: boolean;
showAniList: boolean;
globalSearchConcurrency: number;
globalSearchConcurrency?: number;
}

export interface LibrarySettings {
Expand Down
2 changes: 1 addition & 1 deletion src/screens/GlobalSearchScreen/hooks/useGlobalSearch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const useGlobalSearch = ({ defaultSearchText }: Props) => {
const [searchResults, setSearchResults] = useState<GlobalSearchResult[]>([]);
const [progress, setProgress] = useState(0);

const { globalSearchConcurrency } = useBrowseSettings();
const { globalSearchConcurrency = 5 } = useBrowseSettings();

const globalSearch = (searchText: string) => {
const defaultResult: GlobalSearchResult[] = filteredInstalledPlugins.map(
Expand Down
4 changes: 2 additions & 2 deletions src/screens/browse/settings/BrowseSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const BrowseSettings = ({ navigation }: BrowseSettingsScreenProp) => {
theme={theme}
/>
<ConcurrentSearchesModal
globalSearchConcurrency={globalSearchConcurrency}
globalSearchConcurrency={globalSearchConcurrency ?? 5}
modalVisible={globalSearchConcurrencyModal.value}
hideModal={globalSearchConcurrencyModal.setFalse}
theme={theme}
Expand All @@ -49,7 +49,7 @@ const BrowseSettings = ({ navigation }: BrowseSettingsScreenProp) => {
</List.SubHeader>
<List.Item
title={getString('browseSettingsScreen.concurrentSearches')}
description={globalSearchConcurrency.toString()}
description={(globalSearchConcurrency ?? 5).toString()}
onPress={globalSearchConcurrencyModal.setTrue}
theme={theme}
/>
Expand Down
Loading