Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci dev #3

Merged
merged 11 commits into from
Mar 21, 2022
Merged

Ci dev #3

merged 11 commits into from
Mar 21, 2022

Conversation

tomtrafford
Copy link
Contributor

Adds CI to build the webcontrol zpkg and the docs.

@tomtrafford
Copy link
Contributor Author

I'm not certain if this is the correct way to build the docs. Does this need a conf.py like the other repos?

Copy link

@thomascobb thomascobb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right approach, we basically take malcolmjs docs and hack it about

Comment on lines 60 to 69
- uses: rishabhgupta/split-by@v1
id: split
with:
string: ${{ github.ref }}
split-by: /

# Publish docs
- name: Move to versioned directory
# e.g. master or 0.1.2
run: mv PandABlocks-webcontrol/build/templates "PandABlocks-webcontrol/.github/pages/${{ steps.split.outputs._2 }}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.rst Outdated
PandABlocks-webcontrol
======================

|code_ci| |license|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need docs_ci badge here

Comment on lines 25 to 35
- name: Checkout annotypes
uses: actions/checkout@v2
with:
repository: dls-controls/annotypes
path: annotypes

- name: Checkout pymalcolm
uses: actions/checkout@v2
with:
repository: dls-controls/pymalcolm
path: pymalcolm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might not need these two, I can't remember what make docs looks at...

@tomtrafford tomtrafford merged commit 1d93d85 into master Mar 21, 2022
@tomtrafford tomtrafford deleted the ci-dev branch August 2, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants