Custom localization for each player #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astei
requested changes
Jul 24, 2021
astei
requested changes
Jul 24, 2021
astei
requested changes
Jul 25, 2021
proxy/src/main/java/com/velocitypowered/proxy/connection/client/ConnectedPlayer.java
Outdated
Show resolved
Hide resolved
| @@ -45,6 +46,21 @@ | |||
| */ | |||
| String getUsername(); | |||
|
|
|||
| /** | |||
| * The locale the velocity proxy is translating its messages to. By default {@link PlayerSettings#getLocale()} | |||
There was a problem hiding this comment.
Still not satisfied with this Javadoc. The description is very imprecise - we are not necessarily translating messages at this level.
There was a problem hiding this comment.
Is it better now?
There was a problem hiding this comment.
No, it's not. Perhaps Returns the locale the proxy will use to send messages translated via the Adventure global translator. By default, the value of {@link PlayerSettings#getLocale()} is used..
astei
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a network where the player can choose their language for the network independently of their client language.
Velocity won't cooperate with this, so I have added a method to switch their language with a method.
If not set by a plugin, it will return the default language of the player in the settings object or null if the settings are null(On player login). The result of the getLocale method in the settings object will be unchanged by the set value.