-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Papirus to KDE Plasma 6 #3663
Comments
Relevant post from Nate: |
I was about to make this same issue! Papirus is my favorite icon pack. Looking forward to using it with Plasma 6! |
Panel related adaptions was once mentioned by #3595. |
I support we are waiting for Plasma 6! Papirus is the best set! |
Okay guys, I don't think it is possible to have a solution right now. KDE colour scheme icons currently only have sizes up to 24px in Papirus, but the ones that were previously used inside the Plasma themes need to have 32px and 22px sizes. There's no place for symbolic 32px icons at the moment. And even after figuring out where to put them, the necessary scripts for preparing and converting the icons need to be modified. I managed to assemble a quick-and-dirty solution, but I think it is better not to merge it. We need restructuring. I guess I can finally understand what @SmartFinn meant by his harsh reaction to this change in Plasma 6. |
I could even start adding some necessary 32px symbolic icons myself, perhaps in the apps folder or in a new folder somewhere, but I'm not experienced in the project structure and script writing, so I'll be waiting for Serhii to say his word. |
It looks like KDE has done something similar to Breeze Icons 6. In one of Nate Graham's blog posts he said that Plasma 6 will adapt to the way GNOME uses the -symbolic suffix, which may mean that icon makers can put the symbolic icons in all sizes, alongside the coloured ones. |
@monstorix we could, but as I've said we need some non-trivial restructuring. The situation is dire because symbolic icons which are used in GNOME don't adapt their colour, but the icons with the KDE colourscheme support do. And now they are mixed up. I haven't given it much thought, but it seems like another challenge. |
Sorry, I don't have enough time to install KDE on my laptop to see the changes. I suppose that I wrote a script that converts 16px icons into 22px, and 24px, sometime ago. So it shouldn't be a problem. However, we should find the right icon theme structure at first. Another way is creating a fork for Plasma 6. |
Another thing that may affect the works: |
Honestly, I can't remember any place in GTK where 24px icons are used. GNOME uses 16px in menus, buttons, panel, sidebars, and toolbars. 22px is using for appindicators and tray. |
Well, the GTK compatibility saying is also from Nate. It might not pointed to any specific DEs. |
Couldn't we just use the icons from the Materia theme? They seem to fit quite well! |
Couldn't we just use the icons from the Materia theme? They seem to fit quite well!
The problem is, every icon in materia plasma 5 theme (in all of them, really) has both 32px and 22px shapes inside the file: small icons are used for the panel and the bigger ones appear when you open the systray widget. Papirus has no place for these 32px symbolic icons yet, that's why it's not so simple.
|
We'd have to do a lot of it manually, I guess, but for icons that we don't have in Papirus, we could just extract the 22px versions and put them in a separate SVG |
We'd have to do a lot of it manually, I guess, but for icons that we don't have in Papirus, we could just extract the 22px versions and put them in a separate SVG
That's what i did locally before realising that we need restructuring. I've used plasma theme with materia icons myself.
|
Honestly, I can't remember any place in GTK where 24px icons are used. GNOME uses 16px in menus, buttons, panel, sidebars, and toolbars. 22px is using for appindicators and tray.
@SmartFinn if understand correctly, the KDE developers are talking about compatibility in a broader context — 22px icons aren't present in GTK at all, are they? That's why they want to get rid of them. As for the 24px icons, I actually wasn't able to find if they are used in any of my installed applications, but they are still in the specification and they are used if the app developer chooses to use them, right?
|
The 24px actions icons are often using in GTK-based DE, such as Xfce, in toolbars. However, we're talking about symbolic icons that are mostly 16px. 24px symbolic icons are using in elementaryOS, and in Xfce 4 in few places. |
16px symbolic icons are perfectly scaled to 32px. Rules in index.theme file allow it. |
16px symbolic icons are perfectly scaled to 32px. Rules in index.theme file allow it.
@SmartFinn
Neat, but there's an issue: all of them need to be adapted, because the icons in the symbolic directory lack KDE colour scheme support. For example, there's a pending merge request with symlinks for power profiles in symbolic directiry, but I've tried it and the icons have a different colour on a panel compared to the icons from the panel directory
|
@morganist could you try to add these icons without |
Please make an symbolic icon for Elisa Player to shown on tray. |
@Covkie actually, they do: you have to use Papirus-Dark for these icons to be white, as they can't be themed on Plasma. It was mentioned earlier. |
Additional issue: the same happens in the top-left corner of Plasma Discover when there are no updates or when fetching updates. (Using Plasma-Dark icon theme.) (The icon doesn't change if the entry is highlighted by user selection.) |
@morganist is there no solution for KDE users regarding #3663 (comment)? The peek at desktop and certain weather states being slightly off is quite annoying. Could duplicate icons for KDE be added as a temporary solution? |
@morganist is there no solution for KDE users regarding #3663 (comment)? The peek at desktop and certain weather states being slightly off is quite annoying. Could duplicate icons for KDE be added as a temporary solution?
@Covkie honestly, I think the only way is to get KDE and GNOME to agree on symbolic icons so that all of them work the same way in all DEs and apps. We can't add duplicate icons without deleting the existing ones or splitting the icon theme in two. If we make separate themes for KDE and GNOME, users will get good experience using apps and programs made for their DE and not the other. Libadwaita apps only use these symbolic icons that look out of place next to the others and will probably look bad with standard icons. With that said, if GNOME folks are still considering making icons in libadwaita apps unthemeable... Maybe it would be better to actually remove them.
For now, I don't have the time to follow the ongoing efforts to improve the FreeDesktop icon theme specification, so I would be glad if anyone pointed out to GNOME and KDE devs that theming icons in both environments at the same time is impossible. Really, the most simple solution would be if GNOME didn't use the standard name for the icons if they still intend to interpret the spec in their own non-standard way.
This issue goes way too deep.
|
@Tiagoquix turns out this is intentional, Papirus uses a semi-transparent icon for no available updates: Breeze uses an icon with the same name, but it's not transparent. Do you suggest that we make this icon opaque as well? I guess it makes sense when we already use dots to give this icon a different meaning. |
@ariasyqolani when usind the Papirus git master, the applications icon is already changed to use a symbolic icon. Places icon is named "compass" and it's not possible to make it coloured because it is an actions icon, which are all symbolic. I hope that is clear. |
@niri-san cursor icon is already Papirus. it cannot be changed to be coloured because KDE devs or visual design group decided to only use symbolic icons in accessibility KCM sidebar, not fullcolor icons like everywhere else, and the cursor icon is from actions category, which are all symbolic. it's strange, we probably should ask them about this inconsistency. |
@morganist Thanks for the information! Actually i much prefer the symbolic one |
I apologize for not checking with Breeze firstly, I just checked now, breeze has another variant like the pic you show. |
@morganist Yes, it would make sense to make this opaque too, especially due to the fact that we already have the dots to express different things. Thank you for your explanation. |
When installing an app through Discover there's a very brief time window post-install but after being able to click "Launch" to launch the app that it shows a black download/loading icon. |
when will colored folders be available in Kde 6? at the moment they are only blue |
It's allready here Just follow the procedure below. I use black for my folders. |
Sorry, but Papirus doesn't appear to have such icon. What are you referring to? |
KDE Plasma version 6.2.0 in Discover probably needs new symlinks. On a previous comment, I suggested to turn an update icon from transparent to opaque (see #3663 (comment)). While I still stand for my preference, I would like to make an observation from the new KDE Plasma 6.2.0 update: When fetching updates, the icon in the left is still transparent, which I still prefer it to be opaque (I know Papirus wasn't updated yet).
|
@hazelnot
please read the precious messages in this issue. some icons are always the same colour because they follow gnome's symbolic standard which means the icons are NOT recolourable. Breeze and the rest of Papirus icons, on the other hand, use the main text colour of your theme.
|
So does this mean Papirus will be incompatible with KDE going forward? |
@hazelnot I think you can workaround that by forcing Papirus-Light or Papirus-Dark theme instead of the one that is just "Papirus". |
KDE Plasma 6 seems to have changed the names of some icons used in the system tray / system settings / etc. As a result, these icons will fall back to the default Breeze icon theme, even though Papirus has adequate icons (with different names) for them.
Here is a list of icons that I have noticed so far:
brightness-high-symbolic
,redshift-status-off-symbolic
,redshift-status-on-symbolic
,redshift-status-day-symbolic
: Used in the brightness controllerklipper-symbolic
: Used in the clipboard managernotifications-disabled-symbolic
,notification-active-symbolic
,notification-inactive-symbolic
: Used in the notification managerkdeconnect-tray-symbolic
: Used by KDE Connect(everything above could also have their counterparts without "-symbolic")
network-flightmode-on
: Used by the network managerinput-touchscreen
: Used by system settingsNote that this is not an exhaustive list. Maybe we can refer to the new Breeze icon theme repository to find what's not included in Papirus.
The text was updated successfully, but these errors were encountered: