Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Papirus to KDE Plasma 6 #3663

Open
5 of 6 tasks
lhy7889678 opened this issue Mar 7, 2024 · 102 comments
Open
5 of 6 tasks

Adapt Papirus to KDE Plasma 6 #3663

lhy7889678 opened this issue Mar 7, 2024 · 102 comments

Comments

@lhy7889678
Copy link

lhy7889678 commented Mar 7, 2024

  • Distribution (version): Arch Linux
  • Desktop environment: KDE
  • Installing method: Pacman
  • App name (version): KDE Plasma 6.0.1

KDE Plasma 6 seems to have changed the names of some icons used in the system tray / system settings / etc. As a result, these icons will fall back to the default Breeze icon theme, even though Papirus has adequate icons (with different names) for them.

Here is a list of icons that I have noticed so far:

  • brightness-high-symbolic, redshift-status-off-symbolic, redshift-status-on-symbolic, redshift-status-day-symbolic: Used in the brightness controller
  • klipper-symbolic: Used in the clipboard manager
  • notifications-disabled-symbolic, notification-active-symbolic, notification-inactive-symbolic: Used in the notification manager
  • kdeconnect-tray-symbolic: Used by KDE Connect

(everything above could also have their counterparts without "-symbolic")

Note that this is not an exhaustive list. Maybe we can refer to the new Breeze icon theme repository to find what's not included in Papirus.

@Bingo90
Copy link

Bingo90 commented Mar 7, 2024

The removable devices tray icon also shows a colored version, not a monochrome version - not sure this is intended
grafik

@stengun
Copy link

stengun commented Mar 7, 2024

Relevant post from Nate:
https://pointieststick.com/2023/08/12/how-all-this-icon-stuff-is-going-to-work-in-plasma-6/

@d-avery
Copy link

d-avery commented Mar 7, 2024

I was about to make this same issue! Papirus is my favorite icon pack. Looking forward to using it with Plasma 6!

@monstorix
Copy link
Contributor

Panel related adaptions was once mentioned by #3595.

@archisman-panigrahi
Copy link

archisman-panigrahi commented Mar 8, 2024

Plasma 5
Screenshot_20240307_225216b
Plasma 6 (please ignore the annotation around the battery. Also the power icon changing to Plasma icon is a bug with that applet, it is not a Plasma issue.)
Screenshot_20240308_113036

@dmaliog
Copy link

dmaliog commented Mar 10, 2024

I support we are waiting for Plasma 6! Papirus is the best set!

@morganist
Copy link
Contributor

morganist commented Mar 15, 2024

do we make the symbolic klipper icon to be a generic metal clip icon ( clipboard ) used for clipman in xfce, for example? or perhaps a better solution would be to draw a new icon that would be more similar to the one breeze icon theme uses? ( klipper-symbolic )
also, we have a few klipper icons in various old plasma themes. those could be used too.

morganist added a commit that referenced this issue Mar 15, 2024
@morganist
Copy link
Contributor

Okay guys, I don't think it is possible to have a solution right now. KDE colour scheme icons currently only have sizes up to 24px in Papirus, but the ones that were previously used inside the Plasma themes need to have 32px and 22px sizes. There's no place for symbolic 32px icons at the moment. And even after figuring out where to put them, the necessary scripts for preparing and converting the icons need to be modified. I managed to assemble a quick-and-dirty solution, but I think it is better not to merge it. We need restructuring. I guess I can finally understand what @SmartFinn meant by his harsh reaction to this change in Plasma 6.

@morganist
Copy link
Contributor

I could even start adding some necessary 32px symbolic icons myself, perhaps in the apps folder or in a new folder somewhere, but I'm not experienced in the project structure and script writing, so I'll be waiting for Serhii to say his word.

@monstorix
Copy link
Contributor

I could even start adding some necessary 32px symbolic icons myself, perhaps in the apps folder or in a new folder somewhere

It looks like KDE has done something similar to Breeze Icons 6. In one of Nate Graham's blog posts he said that Plasma 6 will adapt to the way GNOME uses the -symbolic suffix, which may mean that icon makers can put the symbolic icons in all sizes, alongside the coloured ones.

@morganist
Copy link
Contributor

morganist commented Mar 15, 2024

which may mean that icon makers can put the symbolic icons in all sizes, alongside the coloured ones.

@monstorix we could, but as I've said we need some non-trivial restructuring. The situation is dire because symbolic icons which are used in GNOME don't adapt their colour, but the icons with the KDE colourscheme support do. And now they are mixed up. I haven't given it much thought, but it seems like another challenge.

@SmartFinn
Copy link
Member

SmartFinn commented Mar 15, 2024

Sorry, I don't have enough time to install KDE on my laptop to see the changes. I suppose that @monstorix @morganist is right, this is required some major changes to Papirus icon theme. KDE may need 22px, and 24px symbolic icons, that we don't support now.

I wrote a script that converts 16px icons into 22px, and 24px, sometime ago. So it shouldn't be a problem. However, we should find the right icon theme structure at first. Another way is creating a fork for Plasma 6.

@monstorix
Copy link
Contributor

Another thing that may affect the works:
KDE VDG team is currently in the process of fully migrating (redrawing) the 22px Breeze icons to 24px, for better cross-compatibility with GTK size. Which may imply that Plasma will finally settle with 24px for standard monochrome/symbolic icons instead of 22px in current 6.0 version.

@SmartFinn
Copy link
Member

Honestly, I can't remember any place in GTK where 24px icons are used. GNOME uses 16px in menus, buttons, panel, sidebars, and toolbars. 22px is using for appindicators and tray.

@monstorix
Copy link
Contributor

Well, the GTK compatibility saying is also from Nate. It might not pointed to any specific DEs.

@Bingo90
Copy link

Bingo90 commented Mar 18, 2024

Couldn't we just use the icons from the Materia theme? They seem to fit quite well!

@morganist
Copy link
Contributor

morganist commented Mar 19, 2024 via email

@Bingo90
Copy link

Bingo90 commented Mar 19, 2024

Couldn't we just use the icons from the Materia theme? They seem to fit quite well!
The problem is, every icon in materia plasma 5 theme (in all of them, really) has both 32px and 22px shapes inside the file: small icons are used for the panel and the bigger ones appear when you open the systray widget. Papirus has no place for these 32px symbolic icons yet, that's why it's not so simple.

We'd have to do a lot of it manually, I guess, but for icons that we don't have in Papirus, we could just extract the 22px versions and put them in a separate SVG

@morganist
Copy link
Contributor

morganist commented Mar 19, 2024 via email

@morganist
Copy link
Contributor

morganist commented Mar 19, 2024 via email

@SmartFinn
Copy link
Member

@morganist

As for the 24px icons, I actually wasn't able to find if they are used in any of my installed applications, but they are still in the specification and they are used if the app developer chooses to use them, right?

The 24px actions icons are often using in GTK-based DE, such as Xfce, in toolbars. However, we're talking about symbolic icons that are mostly 16px. 24px symbolic icons are using in elementaryOS, and in Xfce 4 in few places.

@SmartFinn
Copy link
Member

@morganist

Papirus has no place for these 32px symbolic icons yet, that's why it's not so simple.

16px symbolic icons are perfectly scaled to 32px. Rules in index.theme file allow it.

@morganist
Copy link
Contributor

morganist commented Mar 19, 2024 via email

@SmartFinn
Copy link
Member

@morganist could you try to add these icons without -symbolic suffix. Maybe it's the right way to add Plasma 6 support to Papirus. Like @hexchain did it in #3606 (comment)

@heddxh
Copy link

heddxh commented Jun 9, 2024

Paprius seems don't have icons for num lock and combined num lock and caps lock. In breeze they are called "input-num-on" and "input-combo-on"
num lock
num + caps lock

@buufmax
Copy link

buufmax commented Jun 12, 2024

Please make an symbolic icon for Elisa Player to shown on tray.

@Tiagoquix
Copy link

Not sure if this was changed, but the "Device" (USB/Pendrives) icon is smaller now in the taskbar (compared to other icons):
image

@Covkie
Copy link
Contributor

Covkie commented Jun 20, 2024

Screenshot_20240620_191832

Weather, Back arrow and Peek desktop icons don't follow system theme

@morganist
Copy link
Contributor

@Covkie actually, they do: you have to use Papirus-Dark for these icons to be white, as they can't be themed on Plasma. It was mentioned earlier.

@Tiagoquix
Copy link

#3663 (comment)

Additional issue: the same happens in the top-left corner of Plasma Discover when there are no updates or when fetching updates. (Using Plasma-Dark icon theme.)

image
image

(The icon doesn't change if the entry is highlighted by user selection.)

@buufmax
Copy link

buufmax commented Jun 24, 2024

Plasma 6.1.0 - System Settings - Accessibility

Screenshot_20240624_231354

Bell & Shake Cursor - Needs to be replaced by Papirus.

@ariasyqolani
Copy link

I think the Places icon in Kickoff should be changed to better align with the other icons in the row
The Screenshot

@Covkie
Copy link
Contributor

Covkie commented Jul 8, 2024

@morganist is there no solution for KDE users regarding #3663 (comment)? The peek at desktop and certain weather states being slightly off is quite annoying. Could duplicate icons for KDE be added as a temporary solution?

@morganist
Copy link
Contributor

morganist commented Jul 8, 2024 via email

@morganist
Copy link
Contributor

morganist commented Jul 8, 2024

@Tiagoquix turns out this is intentional, Papirus uses a semi-transparent icon for no available updates:

image

Breeze uses an icon with the same name, but it's not transparent. Do you suggest that we make this icon opaque as well? I guess it makes sense when we already use dots to give this icon a different meaning.

@morganist
Copy link
Contributor

@ariasyqolani when usind the Papirus git master, the applications icon is already changed to use a symbolic icon. Places icon is named "compass" and it's not possible to make it coloured because it is an actions icon, which are all symbolic. I hope that is clear.

image

@morganist
Copy link
Contributor

@niri-san cursor icon is already Papirus. it cannot be changed to be coloured because KDE devs or visual design group decided to only use symbolic icons in accessibility KCM sidebar, not fullcolor icons like everywhere else, and the cursor icon is from actions category, which are all symbolic. it's strange, we probably should ask them about this inconsistency.

image

@ariasyqolani
Copy link

@morganist Thanks for the information! Actually i much prefer the symbolic one

@buufmax
Copy link

buufmax commented Jul 8, 2024

I apologize for not checking with Breeze firstly, I just checked now, breeze has another variant like the pic you show.
In the meantime, thank you for clarifying the cursor status.

@Tiagoquix
Copy link

@Tiagoquix turns out this is intentional, Papirus uses a semi-transparent icon for no available updates:

image

Breeze uses an icon with the same name, but it's not transparent. Do you suggest that we make this icon opaque as well? I guess it makes sense when we already use dots to give this icon a different meaning.

@morganist Yes, it would make sense to make this opaque too, especially due to the fact that we already have the dots to express different things. Thank you for your explanation.

@Tiagoquix
Copy link

Tiagoquix commented Jul 22, 2024

When installing an app through Discover there's a very brief time window post-install but after being able to click "Launch" to launch the app that it shows a black download/loading icon.

@KweezyCode
Copy link

when will colored folders be available in Kde 6? at the moment they are only blue

@buufmax
Copy link

buufmax commented Jul 29, 2024

when will colored folders be available in Kde 6? at the moment they are only blue

It's allready here
https://github.com/PapirusDevelopmentTeam/papirus-folders

Just follow the procedure below. I use black for my folders.

@morganist
Copy link
Contributor

morganist commented Sep 13, 2024

@buufmax

Papirus on the actions folder already have a similar icon called "network-disconnect-symbolic". I would like that globe to be substituted with network-disconnect-symbolic.svg?

Sorry, but Papirus doesn't appear to have such icon. What are you referring to?

@buufmax
Copy link

buufmax commented Sep 13, 2024

Sorry, but Papirus doesn't appear to have such icon. What are you referring to?

Indeed, Papirus doesn't have such icon.

I was misunderstood by KDE "Select icon", this tool reads missing icons/symbolic from Breeze within icons folder on user location.
Screenshot_20240913_230047
I thought it was part of Papirus, but only currently i searched "network-disconnect-symbolic" within Papirus folder, found there is no such thing.

My mistake, or some bug with that KDE Icon tool.

@Tiagoquix
Copy link

KDE Plasma version 6.2.0 in Discover probably needs new symlinks.

image


On a previous comment, I suggested to turn an update icon from transparent to opaque (see #3663 (comment)). While I still stand for my preference, I would like to make an observation from the new KDE Plasma 6.2.0 update:

When fetching updates, the icon in the left is still transparent, which I still prefer it to be opaque (I know Papirus wasn't updated yet).
image
About the icon in the top-right corner for the "Refresh" button: I think it makes sense. It only is transparent when updates are being fetched, meaning you can't click on the button because it's busy. I would say the current method (making the icon transparent) feels somewhat strange, but I think the culprit here is KDE and not Papirus.


image
The "Up to date" icon and the left icon are probably the same, and like I said earlier I still believe that making them opaque would be the best option.

@Covkie
Copy link
Contributor

Covkie commented Oct 10, 2024

Plasma 6.2 power widget needs some new symlinks/icons
image

@hazelnot
Copy link

Additionally, Plasma supports mixing and matching of a light window theme and dark Plasma theme, especially in 6.2 when setting a Plasma theme different from the window theme respects the user's accent colour. Breeze handles this out of the box, but Papirus sticks to the same icon colour scheme (light/dark) regardless of the different themes. This doesn't happen with all icons, but it does with at least the weather widget and show desktop ones.

I know that sentence was convuluted and possibly confusing, but this is what I mean:
Breeze:
image

Papirus:
image

Papirus-Dark:
image

@morganist
Copy link
Contributor

morganist commented Oct 10, 2024 via email

@hazelnot
Copy link

So does this mean Papirus will be incompatible with KDE going forward?

@Covkie
Copy link
Contributor

Covkie commented Oct 10, 2024

image
6.2 Launcher icons

@Tiagoquix
Copy link

@hazelnot I think you can workaround that by forcing Papirus-Light or Papirus-Dark theme instead of the one that is just "Papirus".

@Tiagoquix
Copy link

Tiagoquix commented Oct 10, 2024

image

Needs symlink for update icon in the system tray (Plasma 6.2.0).

Edit: also for the restart screen.

Discover
image

System tray
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests