Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a Ranked list input modal #26926

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Adds a Ranked list input modal #26926

wants to merge 9 commits into from
+212 −24

Conversation

Contrabang
Copy link
Contributor

@Contrabang Contrabang commented Sep 28, 2024 •
edited
Loading

What Does This PR Do

Adds a Ranked list input modal. It is similar to a tgui list select modal, but instead of selecting one element, the user orders them by preference. When they click submit the order they are in will be set as the result.

Why It's Good For The Game

Makes it a lot easier to take in ranked user inputs. For example, first past the post map voting, or choosing their ERT prefs. (Not implemented in this PR.)

Images of changes

Current version has a little drag handle near each option
image

dreamseeker_JU7u69mVb2.mp4

image
image

Testing

See Above

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict labels Sep 28, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Sep 30, 2024
lewcc
lewcc reviewed Oct 1, 2024
View reviewed changes
code/modules/tgui/tgui_input/ranked_list_input.dm Outdated Show resolved Hide resolved
code/__HELPERS/lists.dm Outdated Show resolved Hide resolved
@Contrabang Contrabang requested a review from lewcc October 1, 2024 23:29
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Oct 10, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Oct 10, 2024
lewcc
lewcc approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't have an amazing grip on TGUI but things look fine

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewcc lewcc lewcc approved these changes

Assignees
No one assigned
Labels
-Status: Awaiting merge This PR is ready for merge TGUI This PR modifies TGUI, will conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Contrabang @lewcc @ParadiseSS13-Bot