Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LORE] Reasonably Sized ERT Lore Drop #26964

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

[LORE] Reasonably Sized ERT Lore Drop #26964

wants to merge 21 commits into from
+45 −44

Conversation

PopeDaveThe3th
Copy link
Contributor

What Does This PR Do

Adds and rewrites a lot of descriptions and lore associated with ERT equipment.

Why It's Good For The Game

lore

also changing the modsuit descriptions is good because we ripped them from tg and they suck

Testing

  • entered game
  • spawned gear
  • observed gear
  • success

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Rewrote a lot of ERT lore
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Oct 2, 2024
@Qwertytoforty
Copy link
Contributor

What does the modsuit look like when fully worn / in its tgui menu? Having such a long name might make it look a bit strange.
Do like most of the added details, not a fan of amber ERT being covered in "cheap plastic" / called low quality, no need to make them seem useless, and they are armored at or higher levels then security armor.

@silverplatedelta silverplatedelta added Tweak This PR tweaks something ingame Lore This PR changes or adds new lore to the game. labels Oct 2, 2024
silverplatedelta
silverplatedelta suggested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@silverplatedelta silverplatedelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few grammatical issues in addition to concerns as making red/amber ERT's appear underfunded/under equipped.

code/modules/clothing/head/helmet.dm Outdated Show resolved Hide resolved
code/modules/clothing/head/helmet.dm Outdated Show resolved Hide resolved
code/modules/clothing/head/helmet.dm Outdated Show resolved Hide resolved
code/modules/clothing/head/helmet.dm Outdated Show resolved Hide resolved
code/modules/clothing/head/helmet.dm Outdated Show resolved Hide resolved
code/modules/clothing/spacesuits/ert_hardsuits.dm Outdated Show resolved Hide resolved
code/modules/clothing/spacesuits/ert_hardsuits.dm Outdated Show resolved Hide resolved
code/modules/clothing/spacesuits/ert_hardsuits.dm Outdated Show resolved Hide resolved
code/modules/clothing/spacesuits/ert_hardsuits.dm Outdated Show resolved Hide resolved
code/modules/clothing/spacesuits/ert_hardsuits.dm Show resolved Hide resolved
PopeDaveThe3th and others added 9 commits October 2, 2024 13:36
@PopeDaveThe3th @silverplatedelta
Update helmet.dm
075fbd8 
Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @silverplatedelta
Update helmet.dm
141ff37 
Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @silverplatedelta
Update helmet.dm
3b59840 
Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @silverplatedelta
Update helmet.dm
96906dc 
Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @silverplatedelta
Update helmet.dm
20d6105 
Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @silverplatedelta
Update ert_hardsuits.dm
0324a54 
Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @silverplatedelta
Update ert_hardsuits.dm
209a486 
Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @silverplatedelta
Update ert_hardsuits.dm
1e80671 
Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @silverplatedelta
Update ert_hardsuits.dm
3fa43fe 
Co-authored-by: Silverplate <118299273+silverplatedelta@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
silverplatedelta
silverplatedelta approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@silverplatedelta silverplatedelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for code/grammar/formatting.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Oct 5, 2024
@PopeDaveThe3th @Gatchapod
Update mod_theme.dm
0cc95ca 
Co-authored-by: Gatchapod <20936555+Gatchapod@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@graphite-app graphite-app bot added the Needs detailed review This PR needs a little more love before it can be merged label Oct 11, 2024
@S34NW S34NW removed the Needs detailed review This PR needs a little more love before it can be merged label Oct 11, 2024
@Henri215 Henri215 added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Oct 14, 2024
@Henri215
Copy link
Member

wiki update needed because of the modsuit name

Henri215
Henri215 reviewed Oct 14, 2024
View reviewed changes
code/modules/clothing/spacesuits/ert_hardsuits.dm Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
PopeDaveThe3th and others added 5 commits October 14, 2024 15:21
@PopeDaveThe3th
capitalized
bc96782
@PopeDaveThe3th
Update ert_hardsuits.dm
b7c5569
@PopeDaveThe3th @Henri215
Update code/modules/mod/mod_theme.dm
d958a24 
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th @Henri215
Update code/modules/mod/mod_theme.dm
bcc45dc 
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Signed-off-by: PopeDaveThe3th <80988376+PopeDaveThe3th@users.noreply.github.com>
@PopeDaveThe3th
Update armor_suits.dm
be6c815
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Onyxarias Onyxarias Onyxarias approved these changes

@Henri215 Henri215 Henri215 approved these changes

@silverplatedelta silverplatedelta silverplatedelta approved these changes

@Fordoxia Fordoxia Awaiting requested review from Fordoxia

@Gatchapod Gatchapod Awaiting requested review from Gatchapod

@Somniworld Somniworld Awaiting requested review from Somniworld

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
-Status: Awaiting merge This PR is ready for merge Lore This PR changes or adds new lore to the game. Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Tweak This PR tweaks something ingame
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@PopeDaveThe3th @Qwertytoforty @Henri215 @Gatchapod @Somniworld @Onyxarias @silverplatedelta @Fordoxia @S34NW @ParadiseSS13-Bot