Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes additions to world.Topic() to make the in-game PR announcer work #3291

Merged
merged 1 commit into from
Jan 20, 2016

Conversation

TheDZD
Copy link
Contributor

@TheDZD TheDZD commented Jan 19, 2016

Don't have a preference for this due to lack of a local SQL server.

🆑 TheDZD
rscadd: Adds world.Topic() handling so that users are notified in-game when pull requests are opened, closed, or merged on the Github repo.
/:cl:

@TheDZD TheDZD added the Feature This PR is a new addition to the game label Jan 19, 2016
@TheDZD
Copy link
Contributor Author

TheDZD commented Jan 19, 2016

Closing and re-opening to test the webhook.

@TheDZD TheDZD closed this Jan 19, 2016
@TheDZD TheDZD reopened this Jan 19, 2016
@TheDZD
Copy link
Contributor Author

TheDZD commented Jan 19, 2016

Looks good, meaning that that inline changelogs should function now as well.

@TheDZD
Copy link
Contributor Author

TheDZD commented Jan 19, 2016

@ParadiseSS13/paradise-maintainers You can yell at people to put changelogs using the format in the OP here.

@MrStonedOne
Copy link
Contributor

Format:

:cl:
prefix: text
prefix: text
prefix: text
/:cl:

Placed in the body of the PR.

You can even add the name to file it under by adding it after the :cl: tag (it will default to your github username if omitted)

Prefixes are directly from the changelog system, see the example changelog file in html/changelogs for more info.

Example: (taken directly from the example.yml file)

:cl: N3X15
rscadd: Added a changelog editing system that should cause fewer conflicts and more accurate timestamps.
rscdel: Killed innocent kittens.
/:cl:

Once your PR is merged, the website will get a notification of such and add a new commit adding the changelog file.

You can also use add as a shortcut for rscadd, del for rscdel, fix/fixes for bugfix, and typo for spellcheck

Multiple :cl: blocks are supported, they will get combined, but only the last declared author is used, (you can't use multiple blocks to have multiple authors, as the changelog file format doesn't support that)

@KasparoVy
Copy link
Contributor

Just to confirm: Every PR after this should be using inline changelogging only?

@TheDZD
Copy link
Contributor Author

TheDZD commented Jan 20, 2016

@KasparoVy Yup, it's much simpler to do, although the effect is the same.

@tigercat2000
Copy link
Contributor

@TheDZD now i fully intend on making yml files just because you said that

@KasparoVy
Copy link
Contributor

@TheDZD Super duper handy! Saves the trouble of having to push an extra commit just to make sure the name of the changelog file is correct lol

Fox-McCloud added a commit that referenced this pull request Jan 20, 2016
Makes additions to world.Topic() to make the in-game PR announcer work
@Fox-McCloud Fox-McCloud merged commit ac7bb33 into ParadiseSS13:master Jan 20, 2016
TheDZD added a commit that referenced this pull request Jan 20, 2016
@TheDZD TheDZD deleted the changelog-1-18-2016 branch January 20, 2016 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR is a new addition to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants