Expose numeric ids for MQTT definitions #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows matching zones (which expose a numeric "partition" value) to the corresponding partition.
|
|
I tried yesterday to dig into the code but did not had time to make anything useful. Your change is great. Thank you for contribution! |
|
Thanks! Happy to contribute, despite I'm not fluent in Python :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a numeric id to definitions (partitions, zones, users) published to MQTT.
This change allows matching zones (which expose a numeric "partition" value) to the corresponding partition.
The original definition is not mutated.