Vic2ToHoI4-0.2D

It's taken longer than I like, but not as long as last time. Here's another big update. There have been a few areas of improvement. First, a bunch of bugfixes! Followed up with a debug mode you can set when converting. If you set debug mode, you'll get more warnings while converting, plus all mapped provinces will have a name, making it easier to double-check province mappings. Speaking of which, much of western europe has had updated province mappings (see the full changelog for details). There are also more flags, country mapping improvments, more localisations, and a FAQ entry for some of you who get the problem where HoI4 doesn't change. There's been more work rebalancing the focuses and ideas. There have been some fixes and improvements to ideologies. Someone asked for an option to only have the default ideologies, and that's in now. I also activated elections and put in all the normal election events, but updated for all ideologies. I did a bunch of work to clean up the code, and also got continuous integration going, so we know right away if there are problems that break the code. Not how many changes it took for me to get that working; Travis-CI is cool but a pain. Also, the code cleanup included fixing some significant slowdowns. It should take about half as long to convert now. Finally, there was a request for an option to leave cores for dead nations. I've put it in, but in the future some other plans should make it unnecessary.

How you can help
First, we can use more portraits. It would help a great deal if you could create new portraits and update cultureGroupToGraphics.txt to point at them correctly. As the name implies, culture groups are mapped to sets of portraits (also, ideologies). I'd like to stick with HoI4's existing art style if possible. However, if you add a truly large number of portraits, I'll not object to you changing the overall style. Bears and Equine portraits are an exception. Feel free to not match the existing style with them, as they're already just in there for fun.

We can use help with female names, callsigns, and company names. Some might be able to be pulled from HoI4. They go in names.txt. Create a debug mod to get a list of missing ones.

We can use help with translations. We have a bunch more localisations in, but they're either translated with google translate or semi-educated edits of default localisations. Either way, they probably need review.

Province mappings are always an issue. Some of @derhochmeister's are in, and there are some more improvements from @derhochmeister that still need integration. If you want to integrate them and make more improvements, that would be very helpful. Or double-check the work in the Americas and western Europe. If you generate a debug mod you can more easily see what got mapped to where.

For the more math or programming types, I can use some assistance with naval base placement. The converter generates a list of border points between provinces, but they aren’t in proper order. I tried fixing that for this release, but was stymied by several provinces in the northern Baltic, with their inlets and bays and fjords. I have the beginnings of an algorithm, but I'm a little stuck on understanding the necessary math. If you'd care to explain it to me or implement it, let me know.

If you know C++ or would like to learn, we can always use more people programming. I’m focused on country internals right now, but you could work on whatever part strikes your fancy, or I could give specific direction. Either way, that’s the biggest aspect of working on the converter.

If you can test, that would be helpful. Catching bugs and oddities earlier means they get fixed earlier. I try to release test versions of the converter on the forum for testing, so running those and looking things over is helpful. With CI now running, I could probably even set up test builds to be automatic. And if you have professional experience in testing, well, I'm sure we could be doing things far better. Tell me how!

We can always use help figuring out how things work, and how we can do them better. If you know how to mod HoI4, we can use your help figuring it out. As well, there's always more room for flavor events, decisions, and the like.

We can always handle more discussion on how things are converted over on the development thread. As well, I try to document implemented items over on the project wiki. And your encouragement helps more than you know.

Bugfixes:

• Fixed the absolutism focus
• Redo the previous focus tree fix because it disappeared from the code
• Fixes for Linux version
• Update mod version number in included configuration file
• Fix some conditionals, to avoid spamming incorrect warnings
• The war creator shouldn't assume relations exist (caused #365)
• When dropping ideologies, don't unnecessarily drop fascism or communism
• Don't try to output invalid country names.
• Add unit types from ultimate mod
• Fix errors with flags
• Add cultures to culture-less countries
• Add DoD icon for Fascist puppets
• Make countries more likely to get an appropriate localisation
• Remove music files - Although this introduces errors for people with music DLC, they are harmless, and it fixes a problem where music would stop playing for those without the music DLCs
• Added dockyards should only go to coastal provinces
• Fixes to Linux build
• Update some utility functions on Linux
• Fix an error with national focuses.
• Handle disappearing countries more gracefully
• Fix an error that both Visual Studio and Travis CI were too forgiving of

Debug mode:

• Keep the localisations from crashing under debug
• Limit the extra logs to debug mode
• When in debug mode, make all provinces mapped to a Vic2 province have labels
• Expose the option to create a debug mod

Data File Updates:

• Flag updates
• Country mapping updates
• Add flags that are the same in HoI4 or have an independent source
• Add some redrawn flags
• Start updating European province mappings:
  - Greenland
  - Iceland
  - UK
  - Ireland
  - Portugal
• Use debug mode to fix province mappings from last changes
• Spain province mappings
• Province mappings in France
• Add a FAQ entry for unchanged HoI4
• Merge province mappings for Benelux
• Don't make the frontend ask for unneeded data
• Merge Norway province mappings
• Organize the order of remaining european provinces
• Incorporate the fix the the uncivilized idea icon
• Add a bunch of localisations
• Add the province renaming event
• Added some missing localisations after my bug report (to Paradox) was shown to be in error
• Make the province renaming event triggered in on_startup

Ideas and Focuses:

• Nerf to monarchy ideas, great power ideas
• Major democracy tree no longer gives militarism idea and send volunteers rule is there only once
• National unity gains nerfed
• Changed monarchy idea icons
• Removed research speed bonus from GP idea
• Fixed Sudeten focus branch creation
• National unity focuses now give 5%
• Limited intervention gives idea that reduces tension requirement before one can send volunteers or lend lease
• PP bonus was moved to prepare intervention to improve that focus
• Absolutists majors had focus that did nothing so now it gives one time industry research bonus
• Added English localizations to a few monarchy related ideas
• Added missing quotation marks to Sudenten event
• Bug fix for GenerateMajorWars call in WarCreator.cpp
• Fix some errors

Ideologies and elections:

• Assign more interesting AIs to the new ideologies
• Add an option to only convert default ideologies
• Ideological support no longer gets changed to neutral if ruling party is neutral
• Set last_election properly
• Set neutrality properly for all cases of keeping ideologies
• Enable elections for all events leading to a democratic government
• Generate on_actions for election events
• Add dynamic ' in government' events
• Add the democratic parties in minority election event
• Convert ideological majority election events
• Remove magnate favors fascism election event, as it's for only one ideology
• Add wartime exception election event
• Add government contested election event
• Remove unused election events
• Add missing opinion modifiers
• Add an election event to choose the winning (democratic) party
• Add localisations for all political parties
• Convert political party names in general
• Add a scrollbar to the event window
• Fix errors in election events caused by no democratic ideology
• Fix a bug with converting ideologies
• Fix a problem with the 'abandon neutral' event in some circumstances

Code cleanup:

• Take recommendations from CppCheck
• Replace Object* with shared_ptr
• Some cleanup using safer functions in object
• Use Object::safeGetObject() to simplify and make safer
• Add a method of getting tokens from a named sub-object
• Another pass of Object::getLeaf()
• Simplify the output name fixing
• A small refactoring of HoI4Focuses
• Don't customize focus trees for countriese that don't need them. Saves quite some time while converting
• Move Vic2Inventions into a mapper instead of recalling it for every country (saves a ton of time on conversion)
• Slightly improve an error message
• For color, use new types to make it hard to pass wrong parameters
• No default constructor for planes
• Some fixes suggested by cppcheck
• Better protections for the ideologies options
• Update config files with the Vic2 saves

Continuous Integration:

• Add a config file for travis.yml
• Rename travis.yml to .travis.yml
• Try putting UNIX line endings in .travis.yml
• Update travis.yml with better scripts, now that it runs
• Try to force travis to use modern tools
• Try something different to get a modern cmake
• Another attempt to update cmake on travis
• Found a script to build cmake instead of installing it
• Correct script in previous commit
• Remove some failing lines that shouldn't be needed anyways
• Another attempt at cleaning up failing lines
• More changes for travis-ci
• Take 2
• Take 3
• Try something else
• Maybe boost wasn't properly included?
• Replace tabs with spaces...
• Fix a permissions problem with the automated builds
• Correct last commit

Other:

• Double-check that provided game folders are actually the game folders
• Make core removal optional