Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added coverage details on contribution guidelines #265

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

tlunet
Copy link
Member

@tlunet tlunet commented Jan 22, 2023

Following #262

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Base: 70.61% // Head: 70.59% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (d712992) compared to base (07db8c0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   70.61%   70.59%   -0.03%     
==========================================
  Files         229      229              
  Lines       19646    19646              
==========================================
- Hits        13874    13869       -5     
- Misses       5772     5777       +5     
Impacted Files Coverage Δ
...C/projects/soft_failure/implicit_sweeper_faults.py 94.44% <0.00%> (-2.09%) ⬇️
...mentations/problem_classes/Van_der_Pol_implicit.py 96.72% <0.00%> (-1.64%) ⬇️
pySDC/projects/soft_failure/generate_statistics.py 74.87% <0.00%> (-0.51%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pancetta pancetta merged commit ecbccf9 into Parallel-in-Time:master Jan 22, 2023
@pancetta
Copy link
Member

In case you wonder why this had an effect on coverage: there's one project which uses 1000s of tests to generate statistics. Looks like this does not have a random seed, so every once in a while the tests behave slightly differently and a few lines are not visited.

@tlunet
Copy link
Member Author

tlunet commented Jan 22, 2023

Looks like fun 😆 ... I was wondering indeed, thanks for the explanations

@tlunet tlunet deleted the contrib-coverage branch January 22, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants