Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #448 and migration to scipy 1.14 #449

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

brownbaerchen
Copy link
Contributor

@brownbaerchen brownbaerchen commented Jun 26, 2024

Python 3.8 is not compatible with scipy 1.14 at this point, so we had to remove it from the tests.

Closes #448

@pancetta
Copy link
Member

How are we doing in terms of 3.12?

@brownbaerchen
Copy link
Contributor Author

How do you mean? On my fork all tests pass with python > 3.8.

@pancetta
Copy link
Member

Do we explicitly test with 3.12?

@brownbaerchen
Copy link
Contributor Author

Yes, we test with 3.9, 3.10, 3.11 and 3.12. I am also developing on 3.12 locally.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.83%. Comparing base (18989d3) to head (9c9b7d7).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   77.38%   77.83%   +0.44%     
==========================================
  Files         327      332       +5     
  Lines       26085    25843     -242     
==========================================
- Hits        20187    20115      -72     
+ Misses       5898     5728     -170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pancetta pancetta merged commit ecb4227 into Parallel-in-Time:master Jun 26, 2024
2 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L.uold will be overwritten when using assignment operator somewhere else
2 participants