Speedup test for WSCC9BusSystem
#450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 77.38% 77.83% +0.44%
==========================================
Files 327 332 +5
Lines 26085 25843 -242
==========================================
- Hits 20187 20114 -73
+ Misses 5898 5729 -169 ☔ View full report in Codecov by Sentry. |
brownbaerchen
pushed a commit
to brownbaerchen/pySDC
that referenced
this pull request
Jun 28, 2024
…n-Time#450) #!!!!!!!!!! WARNING: FLAKEHEAVEN FAILED !!!!!!!!!!: #/Users/thomasbaumann/Documents/pySDC/pySDC/projects/DAE/tests/test_problems.py:2:1: F401 'warnings' imported but unused #/Users/thomasbaumann/Documents/pySDC/pySDC/projects/DAE/tests/test_problems.py:319:121: E501 line too long (124 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/projects/DAE/tests/test_problems.py:349:121: E501 line too long (132 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/projects/DAE/tests/test_problems.py:361:121: E501 line too long (147 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/projects/DAE/tests/test_problems.py:622:5: F401 'pySDC.helpers.stats_helper.get_sorted' imported but unused #/Users/thomasbaumann/Documents/pySDC/pySDC/projects/DAE/tests/test_problems.py:673:29: F541 f-string is missing placeholders #/Users/thomasbaumann/Documents/pySDC/pySDC/projects/DAE/tests/test_problems.py:676:25: F541 f-string is missing placeholders:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current test
test_WSCC9_SDC_detectiontakes quite long time to run. When I wrote this test the intention was to prove theSwitchEstimatorsince at this time there was no test available. However, with #404 this has changed. The detection in this large power system is really expensive and testing this in the CI pipeline is probably not really necessary sincetest_problems.py,Thus I decided to change the test by removing the detection part and only testing the
get_switching_infomethod of the problem class.What do you think about that?