Small fixes #465
Merged
Small fixes #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brownbaerchen
added
girl scout rule
brownbaerchen
added a commit
to brownbaerchen/pySDC
that referenced
this pull request
Jul 29, 2024
* Small fixes * Fix for breaking update of mpi4py #!!!!!!!!!! WARNING: FLAKEHEAVEN FAILED !!!!!!!!!!: #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/controller_classes/controller_nonMPI.py:211:17: E741 ambiguous variable name 'l' #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/controller_classes/controller_nonMPI.py:424:21: E741 ambiguous variable name 'l' #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/controller_classes/controller_nonMPI.py:448:21: E741 ambiguous variable name 'l' #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/controller_classes/controller_nonMPI.py:586:13: E741 ambiguous variable name 'l' #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/controller_classes/controller_nonMPI.py:649:13: E741 ambiguous variable name 'l' #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_2D_FFT.py:11:121: E501 line too long (122 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_2D_FFT.py:16:121: E501 line too long (127 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_2D_FFT.py:28:121: E501 line too long (123 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_2D_FFT.py:31:121: E501 line too long (130 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_2D_FFT.py:97:40: E203 whitespace before ':' #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_2D_FFT.py:202:121: E501 line too long (121 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_2D_FFT.py:208:121: E501 line too long (127 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_2D_FFT.py:220:121: E501 line too long (125 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_2D_FFT.py:223:121: E501 line too long (130 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_MPIFFT.py:10:121: E501 line too long (127 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_MPIFFT.py:16:121: E501 line too long (126 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_MPIFFT.py:22:121: E501 line too long (126 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_MPIFFT.py:23:121: E501 line too long (129 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_MPIFFT.py:172:121: E501 line too long (127 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_MPIFFT.py:179:121: E501 line too long (126 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_MPIFFT.py:185:121: E501 line too long (126 > 120 characters) #/Users/thomasbaumann/Documents/pySDC/pySDC/implementations/problem_classes/AllenCahn_MPIFFT.py:186:121: E501 line too long (129 > 120 characters):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a few typos in Allen-Cahn problems. In the MPI version with forcing, some typos were bugs. Since the bugs only effect runs with a single processor, I don't think it matters too much. All other typos were in comments. Also, in the non-MPI version I removed some unnecessary copying and reshaping.
Also, there is a new version of mpi4py. If you now try to pickle a communicator, it will raise a
ValueErrorfor whatever reason. So we need to add this in the non-MPI controller step instantiation. This update must have been extremely recently because the actions this morning passed, but this one in the meantime failed, in case you don't believe me ;).