TL: first revision for the parallel SDC theory paper #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh? You pushed |
pySDC/core/sweeper.py
Outdated
|
|
||
| def updateVariableCoeffs(self, k): | ||
| """ | ||
| Eventually update QDelta implicit coefficients if variable ... |
There was a problem hiding this comment.
Why Eventually? That sounds like it will come in the future
There was a problem hiding this comment.
Nah, it's just that most preconditioners keep the same coefficient for different k
There was a problem hiding this comment.
Ah, I see! This is a false friend, I guess. https://www.oed.com/search/dictionary/?scope=Entries&q=eventually
There was a problem hiding this comment.
Well, this one was vicious ...
That looks like a problem with the diff on GH. I wouldn't worry about it. |
|
Now is the perfect time to automate linting. I updated mine to ruff this morning myself in less than 2 mins using our guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.