Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_command encoding parameter not used for command string - utf-8 always used instead #174

Closed
pkittenis opened this issue May 22, 2019 · 1 comment · Fixed by #258
Closed

run_command encoding parameter not used for command string - utf-8 always used instead #174

pkittenis opened this issue May 22, 2019 · 1 comment · Fixed by #258

Comments

@pkittenis
Copy link
Member

Bug reports

Steps to reproduce:

  1. run_command(u'a latin-1 command string', encoding='latin-1')
  2. command gets decoded as 'utf-8', while output gets decoded as 'latin-1'

Expected behaviour: Command string gets 'latin-1' encoding.

Actual behaviour: Command string encoding is always 'utf-8'

Additional info: Latest versions.
@pkittenis pkittenis added this to the Quality of life API milestone Dec 3, 2020
@pkittenis pkittenis removed this from the Quality of life API milestone Dec 4, 2020
@pkittenis pkittenis reopened this Dec 8, 2020
@pkittenis pkittenis removed the invalid label Dec 8, 2020
@pkittenis
Copy link
Member Author

Command encoding should not be affected by read encoding or at all.

@pkittenis pkittenis mentioned this issue Dec 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed encoding not used for cmd string. Updated changelog, documentat… ParallelSSH/parallel-ssh
1 participant
@pkittenis