Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed encoding not used for cmd string. Updated changelog, documentat… #258

Merged
merged 3 commits into from
Dec 26, 2020

Conversation

pkittenis
Copy link
Member

…ion, tests.

Resolves #174

@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #258 (c924892) into master (ae932bc) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   95.14%   94.94%   -0.20%     
==========================================
  Files          17       17              
  Lines        1523     1524       +1     
==========================================
- Hits         1449     1447       -2     
- Misses         74       77       +3     
Impacted Files Coverage Δ
pssh/clients/base/parallel.py 97.28% <ø> (-0.91%) ⬇️
pssh/clients/native/parallel.py 96.82% <ø> (ø)
pssh/clients/ssh/parallel.py 100.00% <ø> (ø)
pssh/clients/base/single.py 94.82% <100.00%> (-0.64%) ⬇️
pssh/clients/native/tunnel.py 85.44% <0.00%> (-0.64%) ⬇️
pssh/clients/native/single.py 95.28% <0.00%> (+0.26%) ⬆️
pssh/clients/ssh/single.py 96.98% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae932bc...c924892. Read the comment docs.

@pkittenis pkittenis merged commit 8f4d7c4 into master Dec 26, 2020
@pkittenis pkittenis deleted the cmd_enc branch December 26, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_command encoding parameter not used for command string - utf-8 always used instead
1 participant