Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 81: default to en_US locale when defaults call fails #82

Merged
merged 8 commits into from
Jun 20, 2024
Merged

Issue 81: default to en_US locale when defaults call fails #82

merged 8 commits into from
Jun 20, 2024

Conversation

merken
Copy link
Contributor

@merken merken commented Jun 6, 2024 •
edited by cjlapao
Loading

Description

update the default language to en_US in case it fails

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run tests (npm run test) that prove my fix is effective or that my feature works
  • I have run format check (npm run format-check) that shows any code inconsistency
  • I have updated the CHANGELOG.md file accordingly

@merken merken mentioned this pull request Jun 6, 2024
Closed
@cjlapao cjlapao added bug Something isn't working core Core Changes labels Jun 6, 2024
@cjlapao cjlapao added this to the v1.2.0 milestone Jun 6, 2024
@cjlapao cjlapao linked an issue Jun 6, 2024 that may be closed by this pull request
defaults read -g AppleLanguages returns exit code 1 and stops the initialization of the extension #81
Closed
@merken merken closed this Jun 14, 2024
@merken merken reopened this Jun 20, 2024
cjlapao
cjlapao previously approved these changes Jun 20, 2024
View reviewed changes
@cjlapao cjlapao merged commit cc863fd into Parallels:main Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjlapao cjlapao cjlapao approved these changes

Assignees
No one assigned
Labels
bug Something isn't working core Core Changes
Projects
Parallels Desktop VSCode Extension
Status: ✅ Done
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

defaults read -g AppleLanguages returns exit code 1 and stops the initialization of the extension
2 participants
@merken @cjlapao