Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the macOS VMs support on ARM-based Mac #429

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Fix the macOS VMs support on ARM-based Mac #429

merged 2 commits into from
Dec 15, 2022

Conversation

bineesh-n
Copy link
Contributor

No description provided.

@legal90 legal90 self-assigned this Dec 13, 2022
legal90
legal90 requested changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@legal90 legal90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bineesh-n, @alevlasu
Thank you for your contribution! Could you please check my comments and questions?

Unfortunately, I don't have ARM-based Mac to test it myself, but I trust your solution 👍 .

lib/vagrant-parallels/action/box_register.rb Outdated Show resolved Hide resolved
lib/vagrant-parallels/action/box_register.rb Outdated Show resolved Hide resolved
lib/vagrant-parallels/util/common.rb Outdated Show resolved Hide resolved
lib/vagrant-parallels/action/prepare_clone_snapshot.rb Outdated Show resolved Hide resolved
lib/vagrant-parallels/action/sane_defaults.rb Outdated Show resolved Hide resolved
@bineesh-n bineesh-n changed the title Fixing vagrant commands for m1 mac Fixing 'vagrant up' command for m1 mac Dec 15, 2022
@bineesh-n
Copy link
Contributor Author

Hi @legal90 Thanks for your comments. I've updated the code as per your suggestions now.

@legal90
Copy link
Collaborator

legal90 commented Dec 15, 2022

Thank you @bineesh-n ! I will merge it now.
I'll do my best to verify it and release a new provider version later this week.

P.s. To Parallels folks:
It's really nice to see more people engaged in this project now 👍 . Feel free to reach out to me if you want to add more maintainers to this repo. Otherwise, I can keep maintaining it on my spare time as I have been doing this for the last years .

@legal90 legal90 merged commit 360c0b0 into master Dec 15, 2022
@legal90 legal90 changed the title Fixing 'vagrant up' command for m1 mac Fix the macOS VMs support on ARM-based Mac Dec 19, 2022
@legal90
Copy link
Collaborator

legal90 commented Dec 19, 2022

Released in https://github.com/Parallels/vagrant-parallels/releases/tag/v2.2.6

@legal90 legal90 deleted the macos-vm-m1 branch December 19, 2022 15:20
@legal90 legal90 mentioned this pull request Dec 19, 2022
Closed
@legal90 legal90 mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polonius polonius polonius left review comments

@legal90 legal90 legal90 approved these changes

Assignees

@legal90 legal90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bineesh-n @legal90 @polonius @alevlasu