Add a synced folder class for Mac VMs #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making this change to access the module in guest_cap/darwin/*.rb
|
Thank you, @bineesh-n ! Yes, feel free to merge this PR when you are ready. I can release a new version of |
bineesh-n
approved these changes
May 22, 2023
legal90
changed the title
legal90
added a commit
that referenced
this pull request
May 22, 2023
It's related to the new class for macvm guests: #448
|
@bineesh-n I released it in v2.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the alternative implementation of #446, which is supposed to fix the current issue of mounting synced folders on *.macvm guests: #445
Here I moved the synced folder support for *macvm to a separate class,
SyncedFolderMacVM.It is just a placeholder for now and should still be filled with the proper implementation for macvms, as it was discussed here: #446 (comment)Fixes #445
Closes #446 as superseded