Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect metadata URL when using Plain permalinks structure #151

Closed
GaryJones opened this issue Mar 7, 2021 · 7 comments
Closed

Incorrect metadata URL when using Plain permalinks structure #151

GaryJones opened this issue Mar 7, 2021 · 7 comments

Comments

@GaryJones
Copy link
Contributor

Parsely::get_current_url() strips querystrings, which means it doesn't produce the correct URL when pretty permalinks are not used.

All URLs are the home URL (i.e. https://example.com instead of https://example.com/?p=1 or https://example.com/?page_id=2 etc.).

@GaryJones GaryJones linked a pull request Mar 7, 2021 that will close this issue
@GaryJones GaryJones removed a link to a pull request Mar 7, 2021
@GaryJones GaryJones added this to the 2.4.0 milestone Mar 27, 2021
@hbbtstar
Copy link
Contributor

hbbtstar commented Apr 6, 2021

I suspect this was actually by design, once upon a time: Parsely's backend strips querystring arguments completely, so this implementation followed suit. Given Wordpress' use of the p querystring, I think in addition to fixing this we also have to ask Parsely to explicitly allow the p querystring in its backend (since WP uses it)

@jblz
Copy link
Contributor

jblz commented May 4, 2021

@hbbtstar Any new thoughts here? Is this something we want to / can support on the service-side?

@jblz
Copy link
Contributor

jblz commented May 4, 2021

Should we bump this to a later milestone?

@hbbtstar
Copy link
Contributor

hbbtstar commented May 4, 2021

ah, sorry- I forgot to update this. Yeah, we can make this change: it'll definitely be possible to support these without too much of a lift.

@hbbtstar
Copy link
Contributor

hbbtstar commented May 4, 2021

oh I missed the second comment: this change won't happen in the Parsely backend in the near term, so it's definitely a candidate for bumping imo!

@abelsonlive
Copy link

abelsonlive commented Oct 25, 2021

Is there someway within the context of wp-parsely for the site admin to indicate that they don't use pretty permalinks? If that information could be passed somehow to the backend upon installation, it would allow us to maintain the p or page_id parameters without causing issues with other, non-wordpress sites.

@pauarge
Copy link
Contributor

pauarge commented Oct 26, 2021

Yes, we can tell that from WordPress. However, we can assume that all WordPress sites have it enabled. Even though a site uses pretty permalinks, ?p= will still be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants