-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect metadata URL when using Plain permalinks structure #151
Comments
I suspect this was actually by design, once upon a time: Parsely's backend strips querystring arguments completely, so this implementation followed suit. Given Wordpress' use of the p querystring, I think in addition to fixing this we also have to ask Parsely to explicitly allow the p querystring in its backend (since WP uses it) |
@hbbtstar Any new thoughts here? Is this something we want to / can support on the service-side? |
Should we bump this to a later milestone? |
ah, sorry- I forgot to update this. Yeah, we can make this change: it'll definitely be possible to support these without too much of a lift. |
oh I missed the second comment: this change won't happen in the Parsely backend in the near term, so it's definitely a candidate for bumping imo! |
Is there someway within the context of |
Yes, we can tell that from WordPress. However, we can assume that all WordPress sites have it enabled. Even though a site uses pretty permalinks, |
Parsely::get_current_url()
strips querystrings, which means it doesn't produce the correct URL when pretty permalinks are not used.All URLs are the home URL (i.e.
https://example.com
instead ofhttps://example.com/?p=1
orhttps://example.com/?page_id=2
etc.).The text was updated successfully, but these errors were encountered: