Improving reliability of get_current_url tests #398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the tests on the
get_current_url
function. Concretely, we're changing how we check the results, fromassertStringStartsWith
to the stricterassertEquals
.With this PR, we have tests to prove that if a query parameter, such as
?p=1
gets added to the URL, the function will correctly catch it. This closes an issue (linked below) that pointed to this function not working correctly.Motivation and Context
#151
How Has This Been Tested?
Ran PHPUnit tests locally and in CI.
Types of changes
New feature (non-breaking change which adds functionality)