Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cfasync script attributes opt-in #293

Closed
jblz opened this issue May 6, 2021 · 1 comment · Fixed by #473
Closed

Make cfasync script attributes opt-in #293

jblz opened this issue May 6, 2021 · 1 comment · Fixed by #473
Assignees
Milestone

Comments

@jblz
Copy link
Contributor

jblz commented May 6, 2021

Is your feature request related to a problem?

As mentioned here, there's no need to have these attributes in place for sites that don't use Cloudflare.

It should, therefore, be opt in. Since it's a breaking change, I'm adding it to the 3.0.0 milestone.

Describe the solution you'd like

Either a checkbox in the "Advanced" settings section or a filter to opt-in to this behavior (I'd lean toward the latter).

Describe alternatives you've considered

Additional context

@jblz jblz added this to the 3.0.0 milestone May 6, 2021
@GaryJones
Copy link
Contributor

+1 for the filter approach, and not having a new setting.

We could also make this opt-out for a 2.6.0 release, and then opt-in for the 3.0.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants