Add data-cfasync="false" to script tags #286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current version of the plugin adds a
data-cfasync="false"
attribute pair to the script tags:wp-parsely/parsely-javascript.php
Lines 22 to 24 in de02bbd
wp-parsely/parsely-javascript.php
Line 57 in de02bbd
wp-parsely/class-parsely-recommended-widget.php
Line 67 in de02bbd
This change:
preg_replace
to actually workMotivation and Context
It was intended to replicate this behavior in #236, but it did not make it into the change.
I didn't find a whole lot of context around the need for this, but there's #129. @hbbtstar -- can you please take a look and let me know if this is the right approach?
Some more context: this attribute looks like it's used to have Cloudflare's Rocket Loader "ignore specific JavaScripts."
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes