Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining namespaces #396

Closed
GaryJones opened this issue Sep 23, 2021 · 0 comments · Fixed by #477
Closed

Add remaining namespaces #396

GaryJones opened this issue Sep 23, 2021 · 0 comments · Fixed by #477
Assignees
@pauarge
Labels
Type: Maintenance
Milestone
3.0.0

Comments

@GaryJones
Copy link
Contributor

Is your feature request related to a problem?

Most src/ and tests/ files have got a PHP namespace, but a couple of old ones don't.

Describe the solution you'd like

Add namespaces, and rename the classes as necessary.

Describe alternatives you've considered

Not changing, but then consistency of namespaces is better.

Additional context
@GaryJones GaryJones added this to the 3.0.0 milestone Sep 23, 2021
GaryJones added a commit that referenced this issue Sep 30, 2021
@GaryJones
Add namespaces to files
f972315 
See #396.

Also move widget class into its own directory and namespace.

Also move integration tests around - fixes #425.
GaryJones added a commit that referenced this issue Sep 30, 2021
@GaryJones
Add namespaces to files
0606b55 
See #396.

Also move integration tests around - fixes #425.
@GaryJones GaryJones mentioned this issue Sep 30, 2021
Merged
GaryJones added a commit that referenced this issue Sep 30, 2021
@GaryJones
Add namespaces to some files
2f63b1b 
See #396.

Also move integration tests around - fixes #425.
GaryJones added a commit that referenced this issue Oct 2, 2021
@GaryJones
Add namespaces to some files
723d89e 
See #396.

Also move integration tests around - fixes #425.
GaryJones added a commit that referenced this issue Oct 15, 2021
@GaryJones
Add namespaces to some files
cf75430 
See #396.

Also move integration tests around - fixes #425.
@pauarge pauarge self-assigned this Oct 28, 2021
This was referenced Oct 29, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pauarge pauarge

Labels
Type: Maintenance
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Adding namespace to root class Parsely/wp-parsely
2 participants
@GaryJones @pauarge