Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an autoloader for the plugin's files #961

Closed
acicovic opened this issue Jul 6, 2022 · 5 comments · Fixed by #985 or #2621
Closed

Use an autoloader for the plugin's files #961

acicovic opened this issue Jul 6, 2022 · 5 comments · Fixed by #985 or #2621
Assignees
Labels
Component: PHP Pull requests that update PHP code Type: Maintenance
Milestone

Comments

@acicovic
Copy link
Collaborator

acicovic commented Jul 6, 2022

Is your feature request related to a problem?

Recently, we had to fix a bug due to a forgotten require. @GaryJones, @chriszarate and I agree that moving to an autoloader is a good move. It will help prevent similar issues and allow for cleaner code.

Describe the solution you'd like

Implement an autoloader solution for the plugin's files.

@acicovic acicovic added Type: Maintenance Component: PHP Pull requests that update PHP code labels Jul 6, 2022
@acicovic acicovic added this to the Unassigned milestone Jul 6, 2022
@acicovic
Copy link
Collaborator Author

acicovic commented Jul 9, 2024

Reopening this and adding it to our Summer 2024 milestone. This had been implemented in the past, but we had to roll back due to issues.

We maybe can reuse parts of the old PR, but we should conduct more thorough testing to make sure there are no issues.

@acicovic acicovic reopened this Jul 9, 2024
@acicovic acicovic modified the milestones: Future Milestone, Summer 2024 Jul 9, 2024
@vaurdan
Copy link
Contributor

vaurdan commented Jul 9, 2024

I believe this should be either part of #2426, or done before that work, since all the PHP refactoring work will very much benefit from this change. What do you think?

@acicovic
Copy link
Collaborator Author

acicovic commented Jul 9, 2024

Yes, definitely agree. I prefer this to be isolated work instead of part of #2426, to keep things as atomic as possible.

@vaurdan
Copy link
Contributor

vaurdan commented Jul 9, 2024

Yeah, agree! In that case, I think I will take this one before spending too much time on #2426. I think it could be a relatively easy win.

@acicovic
Copy link
Collaborator Author

acicovic commented Jul 9, 2024

Agreed!

@vaurdan vaurdan linked a pull request Jul 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PHP Pull requests that update PHP code Type: Maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants