Switch to Composer autoloader #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As noted in the description - we may want to add further enhancements/changes before we close the original issue. |
|
@GaryJones, thank you very much for the contribution. Would you have any suspicion about why E2E tests fail the way they do? |
|
All failures seem to stop at |
|
I went ahead in order to make tests pass and apply some autoload file optimizations for E2E tests and the deployment workflow. I think that as things stand, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch to Composer autoloader
Built plugin (i.e. a Zip on GitHub, or what is pushed to WordPress.org, will need to ensure that
composer install --no-dev -ais run, so that Authoritative class maps are created.Motivation and Context
Fixes #961.
How Has This Been Tested?