Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCH Editor Sidebar: Fix incorrect AI opt-in message #2296

Merged
merged 7 commits into from
Mar 19, 2024

Conversation

acicovic
Copy link
Collaborator

Description

An incorrect message was being displayed in the PCH Editor Sidebar for opting into AI features. This PR fixes this by displaying the correct message and also improves the notice's styling which has some display issues.

Motivation and context

The messages we show should be relevant.

How has this been tested?

  • Manual local testing.
  • Automated tests pass.

Screenshots

Before After
image image

@acicovic acicovic marked this pull request as ready for review March 15, 2024 13:20
@acicovic acicovic requested a review from a team as a code owner March 15, 2024 13:20
Copy link
Contributor

@vaurdan vaurdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for working of this! I added a comment that's not directly about your changes, but since we're touching this component, I think it makes sense to update it now.

src/content-helper/common/content-helper-error.tsx Outdated Show resolved Hide resolved
@vaurdan
Copy link
Contributor

vaurdan commented Mar 18, 2024

@acicovic before merging this, can you check #2302 and test if the error notices still need the included CSS fixes? If so, could you move those to the common.scss file?

@acicovic
Copy link
Collaborator Author

@vaurdan, will do, thanks 🙂

@acicovic
Copy link
Collaborator Author

@vaurdan, most of the CSS is still relevant (only removed one line). I agree with you that we might need to improve and move it probably somewhere else. Since moving it though would need some additional testing, I prefer to leave as-is for now and tackle it in a different PR, since we want to release this improvement tomorrow.

That PR would be about errors and the Contact Us message which is considered as an error but isn't. I'd want to make sure there are no clashes happening between the message, the errors, and different parts of the PCH (Sidebar, Dashboard Widget).

Are you OK with that? If yes, let's merge this as-is for now.

@acicovic acicovic requested a review from vaurdan March 18, 2024 15:07
Copy link
Contributor

@vaurdan vaurdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great! Approved 🙂

@acicovic acicovic merged commit d520546 into develop Mar 19, 2024
36 checks passed
@acicovic acicovic deleted the fix/pch-editor-sidebar-incorect-ai-opt-in-message branch March 19, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants