Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCH Smart Linking: Implement Smart Links Reviewing step #2507

Merged
merged 57 commits into from
Jun 6, 2024
Merged

PCH Smart Linking: Implement Smart Links Reviewing step #2507

merged 57 commits into from
Jun 6, 2024

Commits on Apr 4, 2024

  1. Add optional $request parameter to is_available_to_current_user

    @vaurdan
    vaurdan committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    82f7209 View commit details
    Browse the repository at this point in the history

  2. Lower phpstan type coverage param_type to 79.7

    @vaurdan
    vaurdan committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a8dc5a8 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Add Smart Linking models and bare endpoint

    @vaurdan
    vaurdan committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    3751f4d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Merge branch 'refs/heads/develop' into add/smart-linking-links-review

    @vaurdan
    vaurdan committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6080cea View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Start implementing Modal UI

    @vaurdan
    vaurdan committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3f8cd9b View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Implement preview and UI elements

    @vaurdan
    vaurdan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    47a1daf View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Finalize modal with apply and reject actions

    @vaurdan
    vaurdan committed May 6, 2024
    Configuration menu
    Copy the full SHA
    c8f2f55 View commit details
    Browse the repository at this point in the history

  2. Add Remove Link and Select in Editor buttons

    @vaurdan
    vaurdan committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ea5059f View commit details
    Browse the repository at this point in the history

  3. Backend improvements

    @vaurdan
    vaurdan committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b8a91f7 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Improve functionality for existing smart links

    @vaurdan
    vaurdan committed May 7, 2024
    Configuration menu
    Copy the full SHA
    163e0a2 View commit details
    Browse the repository at this point in the history

  2. Add max-height to the sidebar

    @vaurdan
    vaurdan committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c36f2c2 View commit details
    Browse the repository at this point in the history

  3. Fix issue with the onClose callback of the modal

    @vaurdan
    vaurdan committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f89dedb View commit details
    Browse the repository at this point in the history

  4. Sort smart links by block position and offset

    @vaurdan
    vaurdan committed May 7, 2024
    Configuration menu
    Copy the full SHA
    dd15dfb View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge branch 'refs/heads/develop' into add/smart-linking-links-review 

    # Conflicts:
#	src/content-helper/editor-sidebar/smart-linking/component.tsx
    @vaurdan
    vaurdan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    1e7c34b View commit details
    Browse the repository at this point in the history

  2. Rebuild assets

    @vaurdan
    vaurdan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    adaa026 View commit details
    Browse the repository at this point in the history

  3. Rebuild assets

    @vaurdan
    vaurdan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    52461a4 View commit details
    Browse the repository at this point in the history

  4. Implement getting existing smart links to populate the modal

    @vaurdan
    vaurdan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a39561c View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Improve modal sidebar scrolling when navigating the smart links

    @vaurdan
    vaurdan committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a6b0314 View commit details
    Browse the repository at this point in the history

  2. Implement retrieval of the post type for each smart link

    @vaurdan
    vaurdan committed May 14, 2024
    Configuration menu
    Copy the full SHA
    3056819 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Improve sorting and backfilling of existing smart links data

    @vaurdan
    vaurdan committed May 15, 2024
    Configuration menu
    Copy the full SHA
    646ac8e View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Better smart link detection and auto-fixing on save, link removal, an… 

    …d link changing.
    @vaurdan
    vaurdan committed May 17, 2024
    Configuration menu
    Copy the full SHA
    411e313 View commit details
    Browse the repository at this point in the history

  2. Move isReviewModalOpen to the store to be global across the Smart Lin… 

    …king component
    @vaurdan
    vaurdan committed May 17, 2024
    Configuration menu
    Copy the full SHA
    a587087 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Add tooltip to the modal actions

    @vaurdan
    vaurdan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    fb10bd2 View commit details
    Browse the repository at this point in the history

  2. Clean-up code and documentation

    @vaurdan
    vaurdan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    0aeffc4 View commit details
    Browse the repository at this point in the history

  3. Implement the link selection functionality

    @vaurdan
    vaurdan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    0aaab89 View commit details
    Browse the repository at this point in the history

  4. UI & functionality tweaks to the Link Details component

    @vaurdan
    vaurdan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    5ca91ec View commit details
    Browse the repository at this point in the history

  5. Rebuild assets with the "finalized" UI & fix linting

    @vaurdan
    vaurdan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    203ef63 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'refs/heads/develop' into add/smart-linking-links-review 

    # Conflicts:
#	build/admin-settings.asset.php
#	build/content-helper/dashboard-widget.asset.php
#	build/content-helper/editor-sidebar.asset.php
#	build/content-helper/excerpt-generator.asset.php
    @vaurdan
    vaurdan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    2cd2abe View commit details
    Browse the repository at this point in the history

  7. Rebuild assets & fix tests

    @vaurdan
    vaurdan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    76ad877 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Fix some issues with link validation and saving

    @vaurdan
    vaurdan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7b882f9 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Address issue with sorting in some edge cases

    @vaurdan
    vaurdan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6d9606c View commit details
    Browse the repository at this point in the history

  2. Apply code review suggestions

    @vaurdan
    vaurdan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    72d9292 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Alex Cicovic <23142906+acicovic@users.noreply.github.com>
    @vaurdan @acicovic
    vaurdan and acicovic authored May 22, 2024
    Configuration menu
    Copy the full SHA
    470e5cb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'refs/heads/develop' into add/smart-linking-links-review 

    # Conflicts:
#	build/content-helper/editor-sidebar.asset.php
#	build/content-helper/editor-sidebar.js
#	src/content-helper/editor-sidebar/smart-linking/store.ts
    @vaurdan
    vaurdan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    20ee2da View commit details
    Browse the repository at this point in the history

  5. Rebuild assets

    @vaurdan
    vaurdan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    e2d1b00 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/add/smart-linking-links-review' … 

    …into add/smart-linking-links-review
    @vaurdan
    vaurdan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2d49f52 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Merge branch 'develop' into add/smart-linking-links-review

    @acicovic
    acicovic committed May 23, 2024
    Configuration menu
    Copy the full SHA
    2f11932 View commit details
    Browse the repository at this point in the history

  2. class-smart-linking-endpoint.php: Improve comments

    @acicovic
    acicovic committed May 23, 2024
    Configuration menu
    Copy the full SHA
    c2ffc6a View commit details
    Browse the repository at this point in the history

  3. Fix regression with getBlockContent

    @vaurdan
    vaurdan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    edac118 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/add/smart-linking-links-review' … 

    …into add/smart-linking-links-review
    @vaurdan
    vaurdan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    271631e View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Alex Cicovic <23142906+acicovic@users.noreply.github.com>
    @vaurdan @acicovic
    vaurdan and acicovic authored May 23, 2024
    Configuration menu
    Copy the full SHA
    45f1d91 View commit details
    Browse the repository at this point in the history

  6. Update src/Endpoints/class-base-endpoint.php 

    Co-authored-by: Alex Cicovic <23142906+acicovic@users.noreply.github.com>
    @vaurdan @acicovic
    vaurdan and acicovic authored May 23, 2024
    Configuration menu
    Copy the full SHA
    9de4b08 View commit details
    Browse the repository at this point in the history

  7. Performance improvement per code review suggestion.

    @vaurdan
    vaurdan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    ca7d094 View commit details
    Browse the repository at this point in the history

  8. Improve comments in some PHP files

    @acicovic
    acicovic committed May 23, 2024
    Configuration menu
    Copy the full SHA
    c2a173d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'add/smart-linking-links-review' of github.com:Parsely/w… 

    …p-parsely into add/smart-linking-links-review
    @acicovic
    acicovic committed May 23, 2024
    Configuration menu
    Copy the full SHA
    cce7044 View commit details
    Browse the repository at this point in the history

  10. Smart Linking Provider: Improve comments

    @acicovic
    acicovic committed May 23, 2024
    Configuration menu
    Copy the full SHA
    b53ff0e View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Apply whitespace and comment improvements

    @acicovic
    acicovic committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2e870bb View commit details
    Browse the repository at this point in the history

  2. Apply whitespace and comment improvements

    @acicovic
    acicovic committed May 24, 2024
    Configuration menu
    Copy the full SHA
    0df2899 View commit details
    Browse the repository at this point in the history

  3. Apply comment improvements

    @acicovic
    acicovic committed May 24, 2024
    Configuration menu
    Copy the full SHA
    bfa96fb View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Merge branch 'refs/heads/develop' into add/smart-linking-links-review 

    # Conflicts:
#	build/content-helper/editor-sidebar.asset.php
#	build/content-helper/editor-sidebar.js
#	build/content-helper/excerpt-generator.asset.php
    @vaurdan
    vaurdan committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    91a3afe View commit details
    Browse the repository at this point in the history

  2. Rebuild assets

    @vaurdan
    vaurdan committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    017e177 View commit details
    Browse the repository at this point in the history

  3. Apply code review suggestions from @acicovic

    @vaurdan
    vaurdan committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    2a9f29e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into add/smart-linking-links-review

    @acicovic
    acicovic authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    3b8b2c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Merge branch 'develop' into add/smart-linking-links-review

    @acicovic
    acicovic authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    e8ee9ea View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into add/smart-linking-links-review

    @acicovic
    acicovic committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a29a4f6 View commit details
    Browse the repository at this point in the history

  3. Fix tests (hopefully)

    @vaurdan
    vaurdan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f2ef3f0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into add/smart-linking-links-review

    @vaurdan
    vaurdan authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7dc50b7 View commit details
    Browse the repository at this point in the history