-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST API Refactor: Settings namespace implementation #2735
REST API Refactor: Settings namespace implementation #2735
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work! Approving and merging this!
Description
This PR is part of the effort described in #2426, and implements the
settings
endpoint, which is related with specific plugin settings, such as the dashboard widget settings, and the editor sidebar settings.The endpoint implement both a
/settings/{setting}/get
and a/settings/{setting}/set
method, but the main endpoint -/settings/{setting}/
can be used as well, by changing the HTTP verb -GET
to retrieve the settings andPUT
/POST
to update the settings.Here's the overview of the implemented API endpoints:
The old tests have been migrated to new Endpoints testing, and new tests have been implemented when needed.
The UI was also updated to use these new endpoints, with all the code related with the older endpoints being removed as well.
** Note: since this work as based on the
refactor/internal-api-stats
branch, this PR is using that branch as the base. However, once that branch is merged (in #2734), the PR should auto-rebase torefactor/internal-api
.Motivation and context
How has this been tested?
I have validated locally that all the features using the
/settings
endpoint are still working as expected, and added new integration tests to test all the new classes functionalities.