Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API Refactor: Settings namespace implementation #2735

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

vaurdan
Copy link
Contributor

@vaurdan vaurdan commented Aug 30, 2024

Description

This PR is part of the effort described in #2426, and implements the settings endpoint, which is related with specific plugin settings, such as the dashboard widget settings, and the editor sidebar settings.

The endpoint implement both a /settings/{setting}/get and a /settings/{setting}/set method, but the main endpoint - /settings/{setting}/can be used as well, by changing the HTTP verb - GET to retrieve the settings and PUT/POST to update the settings.

Here's the overview of the implemented API endpoints:

/wp-parsely/v2
  ├── /settings
  │   ├── /dashboard-widget
  │   │   ├── /get
  │   │   └── /set
  │   └── /editor-sidebar
  │       ├── /get
  │       └── /set

The old tests have been migrated to new Endpoints testing, and new tests have been implemented when needed.

The UI was also updated to use these new endpoints, with all the code related with the older endpoints being removed as well.

** Note: since this work as based on the refactor/internal-api-stats branch, this PR is using that branch as the base. However, once that branch is merged (in #2734), the PR should auto-rebase to refactor/internal-api.

Motivation and context

How has this been tested?

I have validated locally that all the features using the /settings endpoint are still working as expected, and added new integration tests to test all the new classes functionalities.

@vaurdan vaurdan added this to the Summer 2024 milestone Aug 30, 2024
@vaurdan vaurdan self-assigned this Aug 30, 2024
@vaurdan vaurdan requested a review from a team as a code owner August 30, 2024 12:35
Copy link
Contributor

coderabbitai bot commented Aug 30, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (4)
  • develop
  • add/.*
  • fix/.*
  • update/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Base automatically changed from refactor/internal-api-stats to refactor/internal-api September 5, 2024 14:49
@acicovic acicovic modified the milestones: Summer 2024, 3.17.0 Sep 5, 2024
Copy link
Collaborator

@acicovic acicovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! Approving and merging this!

@acicovic acicovic merged commit b2eb9bb into refactor/internal-api Sep 6, 2024
33 checks passed
@acicovic acicovic deleted the refactor/internal-api-settings branch September 6, 2024 06:31
vaurdan added a commit that referenced this pull request Sep 27, 2024
vaurdan added a commit that referenced this pull request Oct 2, 2024
* Apply suggestions from #2731

* Apply suggestions from #2735

* Add dynamic settings endpoint calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants