Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Rename final *-test.php file to *Test.php #384

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

GaryJones
Copy link
Contributor

Description

Rename a test file.

Motivation and Context

PSR-4 naming is needed for PHPUnit 9.1 support.

PHPUnit 9.1 (needed to be able to test against PHP 8.1) essentially deprecates not using PSR-4 (naming of class and files).

See https://core.trac.wordpress.org/ticket/53010 and https://WordPress/WordPress-Coding-Standards#1995.

Fixes #379.

How Has This Been Tested?

Run the tests before and after and ensure no change in the number of tests that are run.

Screenshots (if appropriate):

Types of changes

  • Maintenance (non-breaking change which improves the code in some way)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PSR-4 naming is needed for PHPUnit 9.1 support.

Fixes #379.
@GaryJones GaryJones requested a review from a team as a code owner September 17, 2021 13:42
@GaryJones GaryJones self-assigned this Sep 17, 2021
@GaryJones GaryJones added this to the 2.6.0 milestone Sep 17, 2021
Copy link
Contributor

@pauarge pauarge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaryJones GaryJones merged commit 00ed966 into develop Sep 17, 2021
@GaryJones GaryJones deleted the fix/test-file-name branch September 17, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename final -test.php test file and remove second PHPUnit directory config entry
2 participants