Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused default logo variable #387

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Conversation

pauarge
Copy link
Contributor

@pauarge pauarge commented Sep 20, 2021

Description

This PR removes a variable that was defined that wasn't used anywhere. This line is related with the default logo configuration, but removing it does not affect its behavior.

Motivation and Context

#330

How Has This Been Tested?

Tested on a WP environment to check that the logo is correctly referenced in the HTML code created by Parse.ly. Also, used the ID to double check that the image wasn't used anywhere.

Types of changes

Bug fix (non-breaking change which fixes an issue)

@pauarge pauarge added this to the 2.6.0 milestone Sep 20, 2021
@pauarge pauarge requested a review from a team as a code owner September 20, 2021 15:06
@pauarge pauarge merged commit a99e1e5 into develop Sep 21, 2021
@pauarge pauarge deleted the remove/unused_default_logo branch September 21, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants