Fix rendering errors when rendering multiple recommendation widgets #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
reviewed
Sep 23, 2021
| @@ -15,7 +15,6 @@ | |||
| .parsely-recommended-widget-entry img { | |||
| float: left; | |||
| margin-right: 15px; | |||
| max-width: 50%; | |||
There was a problem hiding this comment.
How does this change fit in?
There was a problem hiding this comment.
Styles weren't applied correctly in the past and this would result in the image looking too small with the changes in this PR.
GaryJones
reviewed
Sep 23, 2021
…into fix/multiple-widgets
|
@GaryJones If Javascript is disabled, the contents don't load. The only thing that gets rendered is an empty div that doesn't affect the rest of the page. |
GaryJones
reviewed
Sep 24, 2021
|
|
||
| <div class="parsely-recommended-widget" | ||
| data-parsely-widget-display-author="<?php echo esc_attr( isset( $instance['display_author'] ) ? wp_json_encode( boolval( $instance['display_author'] ) ) : false ); ?>" | ||
| data-parsely-widget-display-direction="<?php echo esc_attr( isset( $instance['display_direction'] ) ? $instance['display_direction'] : null ); ?>" |
There was a problem hiding this comment.
Instead of adding null string to the attribute, could an empty string be used instead? Just seems cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If multiple recommendation widgets were set up in a page, only the last one would render. That was caused because the script responsible of rendering the widget was enqueued multiple times, but it only the last enqueue would survive.
This PR changes the logic slightly: the script is still enqueued multiple times, but we take advantage of the fact that it's actually called only once. To render the appropriate widgets, we render an empty div from the PHP side and pass the data to javascript using
dataattributes. Then, the script reads all thedivwith that attributes and renders the actual widget.Motivation and Context
Not exactly this issue, but related: #206
How Has This Been Tested?
Rendered multiple widgets with the same and different configurations in the page.
Screenshots (if appropriate):
Before
After
Types of changes
Bug fix (non-breaking change which fixes an issue)