Add e2e test for the plugin action link #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
changed the base branch from
feature/extract-plugin-action-link
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an e2e test for the plugin action link.
This based on
feature/extract-plugin-action-linkbranch (and so contains the same file changes as it as well as the e2e test and readme file changes). Pulled against the feature branch, as the feature branch adds in a class that the e2e test uses to target an element. PR #401 should be merged first, and then this PR can be rebased on todevelopas per usual, and only the two relevant changed files will be left.The test logs in, activates the plugin, goes to the plugin page, looks for and clicks the Settings link in the Parse.ly plugin row, and then checks if the Settings page is loaded by checking for the Version string we have there.
I also updated the e2e test readme, since
docker-composeris nowdocker compose.Motivation and Context
Ideally, all UI-related code should have an e2e test to check the functionality and behaviour is present.
I'll note that we may not consider the ability to click a Settings link on the Plugins page to be a critical user journey, but whilst we're still very light on e2e tests, I think it's worthwhile to get in, even if it's removed later on.
How Has This Been Tested?
Ran e2e test locally (but had failures - see #402) but verified it was actually correct by watching the test interactively and seeing the pass here in the CI.