Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add admin warning for minimum requirements in 3.0 (#408)" #424

Merged
merged 4 commits into from
Sep 30, 2021
Merged

Revert "Add admin warning for minimum requirements in 3.0 (#408)" #424

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3d1bfe
Revert "Add admin warning for minimum requirements in 3.0 (#408)"
pauarge Sep 30, 2021
58bfc75
Fix identation
pauarge Sep 30, 2021
542c1c0
Merge branch 'develop' into revert/admin-warining-3.0
pauarge Sep 30, 2021
a411200
Merge branch 'develop' into revert/admin-warining-3.0
pauarge Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions src/class-parsely.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,6 @@ public function run() {
// display warning when plugin hasn't been configured.
add_action( 'admin_footer', array( $this, 'display_admin_warning' ) );

// TODO: Remove this warning when version 3.0 is released.
add_action( 'admin_notices', array( $this, 'display_admin_upgrade_warning' ) );

// phpcs:ignore WordPress.WP.CronInterval.CronSchedulesInterval
add_filter( 'cron_schedules', array( $this, 'wpparsely_add_cron_interval' ) );

Expand Down Expand Up @@ -735,28 +732,6 @@ public function display_admin_warning() {
<?php
}

/**
* Display a dismissible admin warning if the current WordPress or PHP versions are below the required minimum for the 3.0 release of wp-parsely
* We should get rid of this warning when we release 3.0
*
* @since 2.6.0
*/
public function display_admin_upgrade_warning() {
global $wp_version;
if ( version_compare( PHP_VERSION, '7.1.0', '>=' ) && version_compare( $wp_version, '5.0', '>=' ) ) {
return;
}

$message = sprintf(
/* translators: %s: Plugin settings page URL */
__( '<strong>The next version of the Parse.ly plugin will not work with the current setup.</strong> WordPress 5.0 and PHP 7.1 will be the <a href="%s">new required minimum versions</a>.', 'wp-parsely' ),
esc_url( 'https://github.com/Parsely/wp-parsely/issues/390' )
);
?>
<div id="message" class="notice notice-error is-dismissible"><p><?php echo wp_kses_post( $message ); ?></p></div>
<?php
}

/**
* Decide whether the admin display warning should be displayed
*
Expand Down